feat(homepageHeader): initial commit #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issue, added missing colors to tailwind config, added missing logos to public images
…ck that github actions updates report to be a pass
…VGR svg imports in Storybook, wrote component test for Content Spotlight
…ed carousel to use live-region to improve accessibility
…text looks centered relative to vertical bar
mfshao
reviewed
Jan 28, 2025
| import profileIcon from '../../../public/icons/HealIcons/Icon-Profile.svg'; | ||
| import helpIcon from '../../../public/icons/HealIcons/Icon-Help.svg'; | ||
|
|
||
| const navLinks = [ |
There was a problem hiding this comment.
I think this component should be able to ready config from this file https://github.com/uc-cdis/heal-data-commons/blob/main/config/heal/navigation.json
| import gen3Logo from '../../../public/images/gen3.png'; | ||
| import ctdsLogo from '../../../public/images/ctds-logo.png'; | ||
| import footerNihLogo from '../../../public/images/footer-nih-logo.png'; | ||
|
|
There was a problem hiding this comment.
can we use the footer config? https://github.com/uc-cdis/heal-data-commons/blob/main/config/heal/footer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/HP-1746
https://ctds-planx.atlassian.net/browse/HP-1747
DESIGN
Header:
Footer:
IMPLEMENTATION
Header:
Footer:
STORYBOOKS
Header:
Footer:
New Features
Improvements