generated from uc-cdis/commons-frontend-app
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spike/story book accessibility ci #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck that github actions updates report to be a pass
…VGR svg imports in Storybook, wrote component test for Content Spotlight
mfshao
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/HP-1889
Dev Notes
When there are accessibility Violations
![image](https://private-user-images.githubusercontent.com/113449836/400859069-ab95b46e-38b8-410e-b9cf-bda4c4ad3fd6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwOTQ4MjEsIm5iZiI6MTczOTA5NDUyMSwicGF0aCI6Ii8xMTM0NDk4MzYvNDAwODU5MDY5LWFiOTViNDZlLTM4YjgtNDEwZS1iOWNmLWJkYTRjNGFkM2ZkNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQwOTQ4NDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ZGE4MjI0Yzk3YjAxOGNmYTQzZDY5YTE4ZDc3OThhMGFmNjE5ODI1YTdlZjJkMWQ5OTM2ZjE4NGVmZTU2Y2UxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.pNWO8MexG6gOcDDf-9DUhyr3jGKxwHbiJN_7mnCNUn4)
![image](https://private-user-images.githubusercontent.com/113449836/400859255-34463973-cf1a-4a1a-8fc5-5280bc77976f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwOTQ4MjEsIm5iZiI6MTczOTA5NDUyMSwicGF0aCI6Ii8xMTM0NDk4MzYvNDAwODU5MjU1LTM0NDYzOTczLWNmMWEtNGExYS04ZmM1LTUyODBiYzc3OTc2Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQwOTQ4NDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hODlkMTQ5MDgyMzQ0YzlhYjIzMGE1ZWYwYzNkNjI2NjYxMjdhMjVhNDM3MDY1YjlkNjJiOWI0YWEyMjhmMDY1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.CW60LErfG8aOsyUvhgw2-xOzJGoyQBfVGywUshhi7cQ)
The accessibility issues can be reproduced in Storybook using
npm run storybook
then clicking the accessibility tab associated with the story and clickinghighlight
. Developers can then see details about the defect and information to help fix it:When there are NO accessibility Violations
![image](https://private-user-images.githubusercontent.com/113449836/400864828-99c5c597-689c-4864-9b44-4af28f77ef5e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwOTQ4MjEsIm5iZiI6MTczOTA5NDUyMSwicGF0aCI6Ii8xMTM0NDk4MzYvNDAwODY0ODI4LTk5YzVjNTk3LTY4OWMtNDg2NC05YjQ0LTRhZjI4Zjc3ZWY1ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQwOTQ4NDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xYTJlYjgzNzA3NmQ5YzVkMzY3NmE1M2FjNzBiNmY3NWFhNzcwMDYyMDkzMGJlNjgxYzg2MzBkYzJiNzgyZTdhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.LifgUKScHYeRnxjadJZW_G48Xo0-zqJvZwQnJRtXVsc)
![image](https://private-user-images.githubusercontent.com/113449836/400865106-8c1a00c2-f1ff-454e-9925-9299c4c618fc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwOTQ4MjEsIm5iZiI6MTczOTA5NDUyMSwicGF0aCI6Ii8xMTM0NDk4MzYvNDAwODY1MTA2LThjMWEwMGMyLWYxZmYtNDU0ZS05OTI1LTkyOTljNGM2MThmYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQwOTQ4NDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMjA2Yjg0YzQ5MDcwOWI0YjgwZmJiYWJhZTU4MDI3NWEwN2YzYTkwYjNiODQ0ZjI2MTY1MGYxZDg0YmQ3YTFhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.koo3CTTvOM_6kOSGJ25MCthROsZNW8upIvbnQgTpwKE)
Using Storybook
![output](https://private-user-images.githubusercontent.com/113449836/402089094-2f73f17d-4f63-40c2-97ba-c682272d99c5.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwOTQ4MjEsIm5iZiI6MTczOTA5NDUyMSwicGF0aCI6Ii8xMTM0NDk4MzYvNDAyMDg5MDk0LTJmNzNmMTdkLTRmNjMtNDBjMi05N2JhLWM2ODIyNzJkOTljNS5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQwOTQ4NDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jNWZkMWFhZTg5MDcyMmIwZmJkYjFjOWE1MzU1M2U2MmNjOTIzYmFlYjU4ODUzMjgwZWNlNjJlM2NlYWMxZTUwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.PNZkzEGlH5MA4K-dA0SiTJGNlJSeelpZ1GTUiy1fiOg)
Use
npm run storybook-test
to run tests from CLIUse
![output](https://private-user-images.githubusercontent.com/113449836/402092321-78e33ae1-a47c-40d0-80e1-4bfedf0972cc.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwOTQ4MjEsIm5iZiI6MTczOTA5NDUyMSwicGF0aCI6Ii8xMTM0NDk4MzYvNDAyMDkyMzIxLTc4ZTMzYWUxLWE0N2MtNDBkMC04MGUxLTRiZmVkZjA5NzJjYy5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQwOTQ4NDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNzEwZmM4YzdhZWI3ODkwZjk1YzlmOTUwOTMzOTUwOTY0ODYzNjBjNGRiMDY5MWQxZTI1NDM4ODIwM2RhZmIzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.JXWxCaK_s-5I4EhkwmrWFturC2iH_FNxNkjxfbXThJg)
npm run storybook
to launch the graphical user interfaceNew Features
Dependency updates