-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move backoff settings as well as other functions out of utils #1209
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 13597038828Details
💛 - Coveralls |
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the ci env pod logs here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me, nice refactoring!
Please find the detailed integration test report here Please find the ci env pod logs here |
return SQLAlchemyDriver(db_conn_url) | ||
|
||
|
||
def send_email(from_email, to_emails, subject, text, smtp_domain): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make sense to me to move send_email
from utils.py
to config.py
, that function has nothing to do with the config. If it can't be in utils
for some reason, you can move it to fence/scripting/google_monitor.py
which is the only file that uses it
Please find the detailed integration test report here Please find the ci env pod logs here |
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/PXP-11392
This PR moves config properties and functions out of utils into config. Utils should be low-level, and thus not reference other namespaces for sake of not inducing circular dependencies.
redesign of #1181
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes