Feat/al2 old dockerfile #1204
Draft
Feat/al2 old dockerfile #1204
+469
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12262743439Details
💛 - Coveralls |
Avantol13
reviewed
Dec 11, 2024
| "missing public key file; expected file to exist: " + pub_filepath | ||
| ) | ||
| # Generate public key from private key | ||
| with open(prv_filepath, "r") as f: |
There was a problem hiding this comment.
why are we doing this in the Python code during runtime? Can we just require that the public key be provided like before?
AlbertSnows
previously approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Approved assuming the pipeline issues are resolved. can you add a description to the PR so I or other reviewers have a better understanding of the purposes of these changes? I don't see any glaring issues, but I highly recommend getting more eyes just in case.
|
Please find the ci env pod logs here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes