VADC-845 #1131
VADC-845 #1131
Conversation
There was a problem hiding this comment.
thanks @tianj7 ! I added some comments and questions. Please take a look.
| email, groups, db_session=current_app.scoped_session() | ||
| ) | ||
|
|
||
| super(CognitoCallback, self).post_login(id_from_idp=id_from_idp) |
There was a problem hiding this comment.
why not just super(CognitoCallback, self).post_login()?
| @@ -16,3 +24,27 @@ def __init__(self): | |||
| super(CognitoCallback, self).__init__( | |||
| idp_name=IdentityProvider.cognito, client=flask.current_app.cognito_client | |||
| ) | |||
|
|
|||
| def post_login(self, user=None, token_result=None, id_from_idp=None): | |||
There was a problem hiding this comment.
token_result is actually used in super.post_login(). Why is it not passed?
| # for each group, assign current user the following resources: | ||
| # /cohort-middleware/{group} | ||
| # with both role_ids: 'cohort_middleware_admin' and 'cohort_middleware_outputs_admin_reader' | ||
| db_session = db_session or current_session |
There was a problem hiding this comment.
db_session is not part of this method's arguments
| they are in on the ADFS server. | ||
| Args: | ||
| groups (list): list of groups to sync | ||
| db_session (flask_sqlalchemy_session.SQLAlchemySession): db session to use |
There was a problem hiding this comment.
db_session is not part of this method's arguments
|
|
||
|
|
||
| def _sync_adfs_groups(gen3_user, groups, current_session, db_session=None): | ||
| db_session = db_session or current_session |
There was a problem hiding this comment.
does not seem to be used?
| Args: | ||
| userinfo (dict): userinfo response | ||
| Return: | ||
| str: list of groups |
There was a problem hiding this comment.
is this a single string (e.g. a comma-separated list)? If yes, where is is split into a real list?
| self.logger.info("Synchronizing arborist with authorization info...") | ||
| success = self._update_authz_in_arborist( | ||
| sess, | ||
| user_projects, |
There was a problem hiding this comment.
I think this is for another feature in Gen3, not related to "team projects" and not reusable as such. Can you please check?
https://ctds-planx.atlassian.net/browse/VADC-845
New Features
Add ability to sync ADFS custom groups from Cognito Login