-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/spike ant d strategy #1639
base: master
Are you sure you want to change the base?
Conversation
…#1626) * fix(cardDescriptionParsing): initial commit (#1612) * fix(cardDescriptionParsing): initial commit * fix(cardDescriptionParsing): ranner linter and fixed error * Bugfix/combo box labels (#1611) * bugfix(comboBoxLabels): Began dev of new select box component, need to resolve issues with setting selectedValue * bugfix(comboBoxLabels): made select box a controllable component, moved IsEnterOrSpace into accessibilityUtils folder * bugfix(comboBoxLabels): removed console.log statements * bugfix(comboBoxLabels): ran linter * bugfix(comboBoxLabels): removed commented code * bugfix(comboBoxLabels): ran linter * bugfix(comboBoxLabels): Added Teams Dropdown test * bugfix(comboBoxLabels): updated Teams Dropdown test * bugfix(comboBoxLabels): removed unneeded div element from TeamDropdown * fix(comboBoxLabels): Updated label text * fix(comboBoxLabels): Updated unit test * VADC-1420: Fixed modal button color to ensure accessibility (#1615) * fix(vadc-1420): Fixed modal button color to ensure accessibility * Updated background/border/hover colors for modal window * (VADC-1430): fix(vaLogoAltText) * VADC-1479: Updated Previous/Next buttons' colors for VA GWAS according to 508 (#1618) * fix(vadc-1479): Updated colors for the GWAS next/previous buttons * fix(vadc-1479): Undo automatic discovery style changes * fix(vadc-1479): Updated class in CSS for Previous/Next buttons * Use updated colors only for active button (#1620) * VADC-1516: Updated colors for the buttons in the GWAS modal according to 508 (#1621) * fix(vadc-1516): Updated colors for the buttons in the GWAS modal * fix(vadc-1516): Unify style order * fix(vadc-1516): Refactor CSS * fix(vadc-1516): Added comment * fix(vadc-1516): Updated text color for the dropdown in the Team's modal * fix(vadc-1516): formatting * fix(vadc-1516): formatting * fix(vadc-1516): formatting * fix(vadc-1516): formatting * fix(vadc-1482): Updated button colors in Eurler diagram * fix(vadc-1482): Updated focus color for the Eurler diagram --------- Co-authored-by: Jarvis <[email protected]>
...replacing it with a more generic error message that applies better to all possible error scenarios
* fix: revert and bring back old data dictionary button component ...from https://github.com/uc-cdis/data-portal/tree/5dc09282573e93f8e11d44f53d65e3cf677256c6/src/Analysis/AtlasDataDictionary/AtlasDataDictionaryButton ...which in turn is a restore from older code #1478 * fix: using AtlasLegacyDataDictionaryButton for the legacy scenario * fix: remove unused variables * fix: fix AtlasLegacyDataDictionaryButton tests * feat: use feature flag legacyDataDictionary instead of analysis app attribute * fix: remove duplicated AtlasDataDictionaryButton css file * fix: use project specific feature flag name
maybe we can try to update to |
Interesting idea! Do you know if antd v5 is 508 compliant? |
I'm not sure, and tbh I don't have a high hope on that. But maybe it will make our patching easier (although it can also goes to the other way) |
Please find the detailed integration test report here Please find the ci env pod logs here |
Investigate RC option (building block of AntD) |
@pieterlukasse Implement fixes at NPM build step (postHTML: https://www.npmjs.com/package/posthtml) Not sure if this would work or not. Requires additional library. Example using Tree matching with AntD component (generated by ChatGPT):
|
Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/VADC-1400
Draft PR for Discussion Purposes
Prototype of Tech Approaches for AntD Remediation.
<label>
element, uniqueid
attributes,for
attributes referencing other DOM nodes etc.