Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: integrate Arborist validation for team project for cohort data endpoints AND remove unused endpoints #83

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Feat: integrate Arborist validation for team project for cohort data endpoints AND remove unused endpoints #83

merged 5 commits into from
Dec 19, 2023

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Dec 14, 2023 •
edited
Loading

Jira Ticket: VADC-839

New Features

  • Add "team project" validation for cohort-middleware cohortData endpoints. This validation is basically an extra authorization validation that checks if cohort access (for any cohorts in variables) is granted to the user through one of his team projects

Bug Fixes

  • Fix the endpoint /cohortdefinition-stats/by-source-id/:sourceid/by-team-project to support a URL query parameter where the "team project" can also start with /

Breaking Changes

  • Removed some endpoints that are NOT used by our current frontend. This will break for any clients that happen to use them. This was preferred over implementing extra "team project" validation for endpoints we're not using anyway.

Base automatically changed from feat/integrate_arborist_validation_for_team_project to feat/team_project_feature December 14, 2023 20:01
@pieterlukasse pieterlukasse force-pushed the feat/integrate_arborist_validation_for_team_project_for_cohort_data_endpoints branch from ab381c9 to 7c22eca Compare December 14, 2023 20:04
@pieterlukasse pieterlukasse changed the title Feat: integrate arborist validation for team project for cohort data endpoints Feat: integrate Arborist validation for team project for cohort data endpoints Dec 14, 2023
@pieterlukasse pieterlukasse force-pushed the feat/integrate_arborist_validation_for_team_project_for_cohort_data_endpoints branch from 7c22eca to 3e20ed1 Compare December 15, 2023 15:56
@pieterlukasse pieterlukasse force-pushed the feat/integrate_arborist_validation_for_team_project_for_cohort_data_endpoints branch from 3e20ed1 to 8e04f96 Compare December 15, 2023 17:07
@pieterlukasse
feat: remove unused endpoints
c38cfad 
Important: these can only be added back with proper changes to ensure
the correct "team project" filtering takes place
@pieterlukasse pieterlukasse changed the title Feat: integrate Arborist validation for team project for cohort data endpoints Feat: integrate Arborist validation for team project for cohort data endpoints AND remove unused endpoints Dec 15, 2023
@pieterlukasse pieterlukasse marked this pull request as ready for review December 15, 2023 17:19
tianj7
tianj7 reviewed Dec 15, 2023
View reviewed changes
controllers/cohortdata.go Outdated Show resolved Hide resolved
@pieterlukasse
fix: add query parameter by-team-project?team-project= to stats endpoint
8b40f1c 
...to support team projects that start with "/"
@pieterlukasse
fix: prefer method TeamProjectValidation
6852e94 
...over the other variation of this method (TeamProjectValidationForCohortIdsList)
@pieterlukasse
fix: fix tests after by-team-project?team-project= to stats endpoint …
f7b7fc7 
…change
tianj7
tianj7 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@tianj7 tianj7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pieterlukasse pieterlukasse merged commit 30fb6b4 into feat/team_project_feature Dec 19, 2023
8 checks passed
@pieterlukasse pieterlukasse deleted the feat/integrate_arborist_validation_for_team_project_for_cohort_data_endpoints branch December 19, 2023 18:22
@pieterlukasse pieterlukasse mentioned this pull request Jan 8, 2024
Merged
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianj7 tianj7 tianj7 approved these changes

@m0nhawk m0nhawk Awaiting requested review from m0nhawk

Assignees
No one assigned
Labels
test-portal-homepageTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterlukasse @tianj7