-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: integrate extra 'team project' validation for concept endpoints #82
Merged
pieterlukasse
merged 8 commits into
feat/team_project_feature
from
feat/integrate_arborist_validation_for_team_project
Dec 14, 2023
Merged
Feat: integrate extra 'team project' validation for concept endpoints #82
pieterlukasse
merged 8 commits into
feat/team_project_feature
from
feat/integrate_arborist_validation_for_team_project
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieterlukasse
commented
Dec 6, 2023
9b94400
to
8c3ee95
Compare
...and add both real and mock implementations. This makes this part easier to test.
pieterlukasse
commented
Dec 11, 2023
pieterlukasse
commented
Dec 11, 2023
...and add respective tests
Base automatically changed from
feat/integrate_team_project_checks
to
feat/team_project_feature
December 13, 2023 13:58
…_validation_for_team_project
tianj7
reviewed
Dec 14, 2023
...which is cohort_definition_id...there is no such thing as "cohort id"
tianj7
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: VADC-618
Breaking Changes
Dependency updates