New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making changes to the audit service to use the new base image. #40

Merged

EliseCastle23 merged 14 commits into master from feat/GPE-1113

Nov 18, 2024

Contributor

EliseCastle23 commented Nov 22, 2023 •

edited

Loading

Improvements

Update to use new Amazon Linux base image and use the same structure as our other python services.
Utilizing "gen3" user instead of "root" for more secure containers
Moving to Poetry to manage our virtual environments
Multi-stage Docker builds for smaller images
Move to Gunicorn


          Making changes to the audit service to use the new base image. Also, …

c27ab69

…ensuring our audit service follows the same as our other services.

github-actions bot added the @requires-audit-service label

github-actions bot commented Nov 22, 2023

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

EliseCastle23 marked this pull request as draft

November 22, 2023 23:15

EliseCastle23 and others added 6 commits

August 12, 2024 09:44


          adding nginx to the audit-service image

b4036e0


          fixing case issue

95a3801


          adding comment and changing localhost to ip address

debc793


          changing command

38cba6e


          Set venv to /env

dde5820


          updating the command

59ce2bd

EliseCastle23 marked this pull request as ready for review

October 16, 2024 19:50

EliseCastle23 added 3 commits

October 16, 2024 13:57


          Merge branch 'master' into feat/GPE-1113

1d7d1d8


          updating poetry lock

ff65eae


          updating gunicorn

6d9ca34

github-actions bot commented Oct 16, 2024

filepath	$$\textcolor{#23d18b}{\tt{passed}}$$	$$\textcolor{#f14c4c}{\tt{failed}}$$	SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_audit\_service.py}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions bot commented Oct 17, 2024

filepath	$$\textcolor{#23d18b}{\tt{passed}}$$	$$\textcolor{#f14c4c}{\tt{failed}}$$	SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_audit\_service.py}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions bot commented Oct 17, 2024

filepath	$$\textcolor{#23d18b}{\tt{passed}}$$	$$\textcolor{#f14c4c}{\tt{failed}}$$	SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_audit\_service.py}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here


          adding asgi back

448332d

github-actions bot commented Oct 17, 2024

filepath	$$\textcolor{#23d18b}{\tt{passed}}$$	$$\textcolor{#f14c4c}{\tt{failed}}$$	SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_audit\_service.py}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions bot commented Oct 21, 2024

filepath	$$\textcolor{#23d18b}{\tt{passed}}$$	$$\textcolor{#f14c4c}{\tt{failed}}$$	SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_audit\_service.py}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions bot commented Oct 22, 2024

filepath	$$\textcolor{#23d18b}{\tt{passed}}$$	$$\textcolor{#f14c4c}{\tt{failed}}$$	SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_audit\_service.py}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions bot commented Oct 22, 2024

Please find the ci env pod logs here

EliseCastle23 added the jenkins-brain label

github-actions bot commented Oct 22, 2024

filepath	$$\textcolor{#23d18b}{\tt{passed}}$$	$$\textcolor{#f14c4c}{\tt{failed}}$$	SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_audit\_service.py}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#23d18b}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{5}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions bot commented Oct 22, 2024

Please find the detailed integration test report here

Please find the ci env pod logs here

haraprasadj removed the jenkins-brain label

EliseCastle23 added the jenkins-brain label

github-actions bot commented Oct 24, 2024

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions bot commented Oct 25, 2024

filepath	$$\textcolor{#23d18b}{\tt{passed}}$$	SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_audit\_service.py}}$$	$$\textcolor{#23d18b}{\tt{5}}$$	$$\textcolor{#23d18b}{\tt{5}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$	$$\textcolor{#23d18b}{\tt{5}}$$	$$\textcolor{#23d18b}{\tt{5}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here


          changing base image to python nginx

4cf74d5


          using poetry as virtual environment

96eada1

EliseCastle23 removed the jenkins-brain label

github-actions bot commented Nov 4, 2024

Please find the ci env pod logs here


          Merge branch 'master' into feat/GPE-1113

a55de71

github-actions bot commented Nov 6, 2024

Please find the ci env pod logs here

github-actions bot commented Nov 7, 2024

filepath	$$\textcolor{#23d18b}{\tt{passed}}$$	SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_audit\_service.py}}$$	$$\textcolor{#23d18b}{\tt{5}}$$	$$\textcolor{#23d18b}{\tt{5}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$	$$\textcolor{#23d18b}{\tt{5}}$$	$$\textcolor{#23d18b}{\tt{5}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

tianj7 approved these changes

View reviewed changes

tianj7 left a comment

lgtm, nice job

jawadqur approved these changes

View reviewed changes

EliseCastle23 merged commit a42522a into master

10 checks passed

EliseCastle23 deleted the feat/GPE-1113 branch

November 18, 2024 17:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@requires-audit-service