Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data licensing #309

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Data licensing #309

wants to merge 9 commits into from

Conversation

Elisa-on-GitHub
Copy link
Collaborator

I updated some of the information on this page and made a link to the software licensing page.

@Elisa-on-GitHub Elisa-on-GitHub requested a review from a team as a code owner January 30, 2025 08:37
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for ubvu-open-handbook ready!

Name Link
🔨 Latest commit b75fb28
🔍 Latest deploy log https://app.netlify.com/sites/ubvu-open-handbook/deploys/679b6454b2cca10008aa8c89
😎 Deploy Preview https://deploy-preview-309--ubvu-open-handbook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25
Accessibility: 82
Best Practices: 100
SEO: 90
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Summary

Status Count
🔍 Total 499
✅ Successful 381
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 103
❓ Unknown 0
🚫 Errors 15

Errors per input

Errors in topics/qualtrics.qmd

Errors in topics/data-documentation.qmd

Errors in guides/publish-and-share.qmd

Errors in topics/finding-existing-data.qmd

Errors in topics/metadata.qmd

Errors in topics/bazis.qmd

Errors in topics/selecting-data.qmd

Errors in topics/snellius.qmd

Errors in topics/data-publication.qmd

Errors in guides/data-lifecycle.qmd

Errors in topics/data-collection.qmd

Errors in topics/software-licensing.qmd

@Elisa-on-GitHub
Copy link
Collaborator Author

I noticed in the preview that this change does not render correctly in the guide. I will investigate.

The header Licensing was missing so that it seemed as if licences were part of PIDs. I hope this fixes that.
Copy link
Contributor

Summary

Status Count
🔍 Total 484
✅ Successful 366
⏳ Timeouts 2
🔀 Redirected 0
👻 Excluded 103
❓ Unknown 0
🚫 Errors 13

Errors per input

Errors in topics/metadata.qmd

Errors in topics/data-documentation.qmd

Errors in guides/data-lifecycle.qmd

Errors in topics/bazis.qmd

Errors in topics/qualtrics.qmd

Errors in topics/software-licensing.qmd

Errors in guides/publish-and-share.qmd

Errors in topics/data-collection.qmd

Errors in topics/selecting-data.qmd

Errors in topics/snellius.qmd

Errors in topics/finding-existing-data.qmd

Errors in topics/data-publication.qmd

Copy link
Contributor

Summary

Status Count
🔍 Total 484
✅ Successful 365
⏳ Timeouts 1
🔀 Redirected 0
👻 Excluded 103
❓ Unknown 0
🚫 Errors 15

Errors per input

Errors in topics/data-collection.qmd

Errors in topics/qualtrics.qmd

Errors in topics/selecting-data.qmd

Errors in topics/data-publication.qmd

Errors in guides/publish-and-share.qmd

Errors in topics/finding-existing-data.qmd

Errors in topics/software-licensing.qmd

Errors in topics/data-documentation.qmd

Errors in topics/bazis.qmd

Errors in guides/plan-and-design.qmd

Errors in topics/snellius.qmd

Errors in guides/data-lifecycle.qmd

Errors in topics/metadata.qmd

@Elisa-on-GitHub Elisa-on-GitHub marked this pull request as draft January 30, 2025 10:44
Copy link
Contributor

Summary

Status Count
🔍 Total 39
✅ Successful 31
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 5
❓ Unknown 0
🚫 Errors 3

Errors per input

Errors in guides/publish-and-share.qmd

Errors in topics/software-licensing.qmd

Copy link
Collaborator

@Jolien-S Jolien-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, let's include it in the Handbook.

Copy link
Contributor

Summary

Status Count
🔍 Total 39
✅ Successful 31
⏳ Timeouts 1
🔀 Redirected 0
👻 Excluded 5
❓ Unknown 0
🚫 Errors 2

Errors per input

Errors in topics/software-licensing.qmd

Errors in guides/publish-and-share.qmd

- Changed spelling of license to licence (British spelling, see #303) where appropriate (not where it's the name of a licence or where GitHub calls it license).
- To be fixed: line 35 - the image doesn't exist
Copy link
Contributor

Summary

Status Count
🔍 Total 39
✅ Successful 31
⏳ Timeouts 1
🔀 Redirected 0
👻 Excluded 5
❓ Unknown 0
🚫 Errors 2

Errors per input

Errors in topics/software-licensing.qmd

Errors in guides/publish-and-share.qmd

…n.png

Moving this file so the image displays correctly
Copy link
Contributor

Summary

Status Count
🔍 Total 39
✅ Successful 31
⏳ Timeouts 1
🔀 Redirected 0
👻 Excluded 5
❓ Unknown 0
🚫 Errors 2

Errors per input

Errors in topics/software-licensing.qmd

Errors in guides/publish-and-share.qmd

Copy link
Contributor

Summary

Status Count
🔍 Total 39
✅ Successful 31
⏳ Timeouts 1
🔀 Redirected 0
👻 Excluded 5
❓ Unknown 0
🚫 Errors 2

Errors per input

Errors in topics/software-licensing.qmd

Errors in guides/publish-and-share.qmd

@Elisa-on-GitHub Elisa-on-GitHub marked this pull request as ready for review January 30, 2025 11:48
@Elisa-on-GitHub
Copy link
Collaborator Author

A brief summary of what this PR does:

  • It changes the text about data licences on the page Data Licensing
  • It adds a reference to the Software Licensing page
  • It adds a header to the Software Licensing page and fixes the error with the image not rendering
  • It changes licenses to licences where appropriate in both of the abovementioned topics, in accordance with British English spelling or American English? #303
  • It adds headers to the Guide Archiving and Publishing Data to make clearer what the text is about and changed the header 'number' (i.e. number of hashes) to make clearer how the guide is structured

@Jolien-S I am sorry - once I realised that this PR took more work than I'd initially anticipated, I converted it back to draft, but you'd done your review in the meantime. Would you mind reviewing this again?
In particular, would you mind having a look at the guide and its internal structure? I'm a bit uncertain about the situation as screenshotted below:

image

The header 'Software licensing' is still part of the Data Licences section, but almost immediately afterwards there is a new header with Software Licensing that gives the actual information. This happens because the guide pulls these sections from their respective topic pages and if we want to change this, we have to change something in the topics. Do you have any suggestions? Remove the software licensing header in the Data Licensing page and refer to software licensing only in one sentence?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants