feat: add luks-enable-tpm2-autounlock-specified-disk script#485
Open
ion-ize wants to merge 3 commits intoublue-os:mainfrom
Open
feat: add luks-enable-tpm2-autounlock-specified-disk script#485ion-ize wants to merge 3 commits intoublue-os:mainfrom
ion-ize wants to merge 3 commits intoublue-os:mainfrom
Conversation
The existing script would only enable LUKS TPM unlock for the root disk, this will now allow any LUKS encrypted disk to be enabled for TPM auto-unlock.
dosubot
bot
added
size:L
ion-ize
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing script would only enable luks TPM unlock for the root disk, this script will allow any luks encrypted disk to be enabled for TPM auto-unlock.
I am fairly new to scripting so if anything can be improved please please please feel free to let me know or make any changes you see fit!
The main thing I am not certain of being the most ideal is the method of which I am using to get the list of luks disks.
I also figured this would be better handled as a separate script from the existing enable one since that works perfectly for the root drive. This is really only for people who want additional drives encrypted and to also be auto-unlocked with their TPM.
I am also not sure if this is the best place to submit this or not. If there is a better upstream location for this then I can submit it there instead.