[codex] expose model context windows#31
Conversation
|
@codex review |
|
✅ Actions performedReview triggered.
|
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR extends the model capabilities system to propagate three numeric fields— Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
context_window_tokens,max_context_window_tokens, andauto_compact_token_limit_tokensfromGET /uos/models/capabilitieswhile keeping/v1/modelsOpenAI-shaped.Why
Clients need context-window limits, but OpenAI-compatible
/v1/modelsshould not grow gateway-only fields. The gateway-specific capabilities endpoint is the right place for this metadata.Validation
deno fmt scripts/codex-models.ts src/openai.ts src/admin.ts tests/codex-models.test.ts tests/openai-compat.test.ts tests/admin-auth.test.ts static/chat.js README.md static/docs/llms-agents.mddeno lint scripts/codex-models.ts src/admin.ts src/openai.ts tests/codex-models.test.ts tests/admin-auth.test.ts tests/openai-compat.test.ts static/chat.jsdeno test -A tests/codex-models.test.ts tests/admin-auth.test.ts tests/openai-compat.test.tsdeno task builddeno task lintdeno test --env --allow-env=VOYAGEAI_API_KEYNote:
deno task testcurrently fails ondevelopmentbecausetests/embeddings.test.tsreadsVOYAGEAI_API_KEYbut the task does not grant that env permission. I kept that unrelated config fix out of this PR; local branchcodex/fix-test-env-permissioncontains the one-line task change.