Skip to content

[codex] Enforce OpenAI reasoning compliance#30

Merged
0x4007 merged 2 commits into
developmentfrom
codex/openai-reasoning-compliance
May 15, 2026
Merged

[codex] Enforce OpenAI reasoning compliance#30
0x4007 merged 2 commits into
developmentfrom
codex/openai-reasoning-compliance

Conversation

@0x4007

@0x4007 0x4007 commented May 10, 2026

Copy link
Copy Markdown
Member

Summary

  • normalize upstream null reasoning metadata to the OpenAI wire value \none\
  • share the reasoning dropdown between chat playground and admin defaults
  • reject explicit null reasoning fields in OpenAI-compatible request handling
  • document the no-drift OpenAI API compliance rule in AGENTS.md

Validation

  • deno lint
  • deno task build
  • deno test --env --allow-env=VOYAGEAI_API_KEY

@github-actions

github-actions Bot commented May 10, 2026

Copy link
Copy Markdown

@0x4007 0x4007 marked this pull request as ready for review May 15, 2026 07:01
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@0x4007 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 32 minutes and 38 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 10bcf555-117a-4231-96d0-66aa4fe0aee4

📥 Commits

Reviewing files that changed from the base of the PR and between 3f7a10f and 65e7922.

📒 Files selected for processing (16)
  • AGENTS.md
  • scripts/codex-models.ts
  • src/admin.ts
  • src/openai.ts
  • src/static.ts
  • static/admin.html
  • static/admin.js
  • static/chat.html
  • static/chat.js
  • static/docs/llms-agents.md
  • static/reasoning-select.js
  • tests/admin-auth.test.ts
  • tests/codex-models.test.ts
  • tests/openai-compat.test.ts
  • tests/reasoning-select.test.ts
  • tests/static-assets.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/openai-reasoning-compliance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2daba649b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread static/reasoning-select.js Outdated
Comment on lines +81 to +82
appendOption(select, noneValue, noneLabel);
optionValues.push(noneValue);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Hide None when the model does not support it

For models whose stored supported_reasoning_levels do not include none (for example existing/pre-gpt-5.1 Codex snapshots with only low, medium, high, xhigh), this unconditionally advertises a None choice even though the updated backend validation in src/openai.ts rejects explicit none unless it is listed. Selecting it in chat sends reasoning_effort: "none", and selecting it in admin defaults saves the same value, so users are led into a 400 instead of seeing only supported efforts plus Default.

Useful? React with 👍 / 👎.

@0x4007 0x4007 merged commit bff5ac7 into development May 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant