Highlight component when dragging on X and Y not taking Y margin into account #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…ableX and enableY are set to account for the vertical margin and prevent inaccuracies in y selection.
s-heap
force-pushed
the
bug/highlight-y-margin-patch
branch
from
8396b3f
to
a422525
Compare
|
I think this was handled in another PR, try rebasing and see where you get. (Also thanks for contributing it's big appreciated) |
|
I've had a look but haven't been able to find a relevant pull request for this issue. |
|
i 100% misremembered my bad, long week. the other pr resolved a similar error in a different place in the code |
|
That's fair I understand. I've come across a few errors and issues that I think are linked to the system not taking margins properly into account but this is the only one I've found and nailed down as of yet. |
|
I there any chance this will be merged any time soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "- marginTop" in the _convertAreaToCoordinates function when enableX and enableY are set to account for the vertical margin and prevent inaccuracies in y selection.
A pull request to fix the issue mentioned in #1238 regarding the highlight component inaccuracies.