Open
Conversation
Contributor
|
The title can be shorted to |
phliar
suggested changes
Jun 21, 2019
|
|
||
| columnsPattern = regexp.MustCompile(`columns\s*=\s*\(([^\(\)]+)\)`) | ||
|
|
||
| defunctPattern = regexp.MustCompile(`defunct\s*=\s*(true|false)`) |
Contributor
There was a problem hiding this comment.
Does it have to be defunct=true? I'd like to be able to simply say something like
Index `dosa:"key=(foo,bar),defunct"`
|
Gang Zhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cassandra doesn’t support changing columns of the materialized view. Therefore It introduces the concern that how to handle the existing index table since the goal of the feature is to reduce the large partition.
The current solution is to educate users to mark their old index table as
defunctand then create a new index table with limited columns.The next time users use range query, the gateway would skip the lookup in defunct index table.