Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

Definition Of Done

Masood Abdolian edited this page Aug 10, 2022 · 2 revisions

Clear scope

Create separated PRs for each component or context. For example, a PR can contain some files that are related to 'button.*'.

Script tag in the svelte file

  • Arrange each line in the order of properties, constants, variables, reactive variables, external methods, internal methods, and lifecycles.

Property

  • Properties should have a description or be marked whit a 'TODO' comment.
  • Properties should be sorted alphabetically.
  • Default of boolean properties should be false, no need 'undefined' value for them.
  • If possible, monosyllabic names should be used.

Story

  • Name of the stories should be title case. for example, 'This Is A Sample'.

Variables and functions

  • Use meaningful names for variables. For example, use 'button' instead of 'btn'
Clone this wiki locally