Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minecraft): disable rcon #4427

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix(minecraft): disable rcon #4427

merged 1 commit into from
Jan 31, 2025

Conversation

tyriis
Copy link
Owner

@tyriis tyriis commented Jan 31, 2025

No description provided.

@tyriis-automation
Copy link
Contributor

--- kubernetes/talos-flux/apps/gaming-public/minecraft-java/velocity-proxy Kustomization: flux-system/minecraft-public-velocity-proxy HelmRelease: gaming-public/minecraft-public-velocity-proxy

+++ kubernetes/talos-flux/apps/gaming-public/minecraft-java/velocity-proxy Kustomization: flux-system/minecraft-public-velocity-proxy HelmRelease: gaming-public/minecraft-public-velocity-proxy

@@ -32,39 +32,33 @@

       velocity:
         annotations:
           reloader.stakater.com/auto: 'true'
         containers:
           app:
             env:
-              ENABLE_RCON: 'true'
+              ENABLE_RCON: 'false'
               GID: '1000'
               MEMORY: 256M
               PLUGINS: https://download.geysermc.org/v2/projects/geyser/versions/latest/builds/latest/downloads/velocity,https://download.geysermc.org/v2/projects/floodgate/versions/latest/builds/latest/downloads/velocity
               SPIGOT_PLUGIN: '78915'
               TYPE: VELOCITY
               TZ: Europe/Vienna
               UID: '1000'
               VELOCITY_BUILD_ID: latest
               VELOCITY_VERSION: latest
-            envFrom:
-            - secretRef:
-                name: bungeecord-rcon
             image:
               repository: itzg/bungeecord
               tag: latest@sha256:82b6a7b7d9aefbee26ce2c95e399d5e8dde073f5e6e87e6462f4016fca9f52f3
             nameOverride: minecraft-public-velocity-proxy
             ports:
             - containerPort: 25565
               name: velocity
               protocol: TCP
             - containerPort: 19132
               name: bedrock
               protocol: UDP
-            - containerPort: 25575
-              name: rcon
-              protocol: TCP
             probes:
               liveness:
                 enabled: true
                 port: 25565
                 type: TCP
               readiness:
@@ -115,19 +109,12 @@

         type: persistentVolumeClaim
       tmp:
         globalMounts:
         - path: /tmp
         type: emptyDir
     service:
-      rcon:
-        controller: velocity
-        ports:
-          rcon:
-            port: 25575
-            protocol: TCP
-            targetPort: rcon
       velocity:
         annotations:
           io.cilium/lb-ipam-ips: 192.168.1.86
         controller: velocity
         ports:
           bedrock-proxy:

@tyriis-automation
Copy link
Contributor

--- HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy-rcon

+++ HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy-rcon

@@ -1,22 +0,0 @@

----
-apiVersion: v1
-kind: Service
-metadata:
-  name: minecraft-public-velocity-proxy-rcon
-  labels:
-    app.kubernetes.io/instance: minecraft-public-velocity-proxy
-    app.kubernetes.io/managed-by: Helm
-    app.kubernetes.io/name: minecraft-public-velocity-proxy
-    app.kubernetes.io/service: minecraft-public-velocity-proxy-rcon
-spec:
-  type: ClusterIP
-  ports:
-  - port: 25575
-    targetPort: rcon
-    protocol: TCP
-    name: rcon
-  selector:
-    app.kubernetes.io/component: velocity
-    app.kubernetes.io/instance: minecraft-public-velocity-proxy
-    app.kubernetes.io/name: minecraft-public-velocity-proxy
-
--- HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy-velocity

+++ HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy-velocity

@@ -1,28 +0,0 @@

----
-apiVersion: v1
-kind: Service
-metadata:
-  name: minecraft-public-velocity-proxy-velocity
-  labels:
-    app.kubernetes.io/instance: minecraft-public-velocity-proxy
-    app.kubernetes.io/managed-by: Helm
-    app.kubernetes.io/name: minecraft-public-velocity-proxy
-    app.kubernetes.io/service: minecraft-public-velocity-proxy-velocity
-  annotations:
-    io.cilium/lb-ipam-ips: 192.168.1.86
-spec:
-  type: LoadBalancer
-  ports:
-  - port: 19132
-    targetPort: bedrock
-    protocol: UDP
-    name: bedrock-proxy
-  - port: 25565
-    targetPort: velocity
-    protocol: TCP
-    name: velocity-proxy
-  selector:
-    app.kubernetes.io/component: velocity
-    app.kubernetes.io/instance: minecraft-public-velocity-proxy
-    app.kubernetes.io/name: minecraft-public-velocity-proxy
-
--- HelmRelease: gaming-public/minecraft-public-velocity-proxy Deployment: gaming-public/minecraft-public-velocity-proxy

+++ HelmRelease: gaming-public/minecraft-public-velocity-proxy Deployment: gaming-public/minecraft-public-velocity-proxy

@@ -41,13 +41,13 @@

       hostNetwork: false
       hostPID: false
       dnsPolicy: ClusterFirst
       containers:
       - env:
         - name: ENABLE_RCON
-          value: 'true'
+          value: 'false'
         - name: GID
           value: '1000'
         - name: MEMORY
           value: 256M
         - name: PLUGINS
           value: https://download.geysermc.org/v2/projects/geyser/versions/latest/builds/latest/downloads/velocity,https://download.geysermc.org/v2/projects/floodgate/versions/latest/builds/latest/downloads/velocity
@@ -60,15 +60,12 @@

         - name: UID
           value: '1000'
         - name: VELOCITY_BUILD_ID
           value: latest
         - name: VELOCITY_VERSION
           value: latest
-        envFrom:
-        - secretRef:
-            name: bungeecord-rcon
         image: itzg/bungeecord:latest@sha256:82b6a7b7d9aefbee26ce2c95e399d5e8dde073f5e6e87e6462f4016fca9f52f3
         livenessProbe:
           failureThreshold: 3
           initialDelaySeconds: 0
           periodSeconds: 10
           tcpSocket:
@@ -79,15 +76,12 @@

         - containerPort: 25565
           name: velocity
           protocol: TCP
         - containerPort: 19132
           name: bedrock
           protocol: UDP
-        - containerPort: 25575
-          name: rcon
-          protocol: TCP
         readinessProbe:
           failureThreshold: 3
           initialDelaySeconds: 0
           periodSeconds: 10
           tcpSocket:
             port: 25565
--- HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy

+++ HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy

@@ -0,0 +1,28 @@

+---
+apiVersion: v1
+kind: Service
+metadata:
+  name: minecraft-public-velocity-proxy
+  labels:
+    app.kubernetes.io/instance: minecraft-public-velocity-proxy
+    app.kubernetes.io/managed-by: Helm
+    app.kubernetes.io/name: minecraft-public-velocity-proxy
+    app.kubernetes.io/service: minecraft-public-velocity-proxy
+  annotations:
+    io.cilium/lb-ipam-ips: 192.168.1.86
+spec:
+  type: LoadBalancer
+  ports:
+  - port: 19132
+    targetPort: bedrock
+    protocol: UDP
+    name: bedrock-proxy
+  - port: 25565
+    targetPort: velocity
+    protocol: TCP
+    name: velocity-proxy
+  selector:
+    app.kubernetes.io/component: velocity
+    app.kubernetes.io/instance: minecraft-public-velocity-proxy
+    app.kubernetes.io/name: minecraft-public-velocity-proxy
+

@tyriis-automation
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.91s
✅ YAML prettier 1 0 0.37s
✅ YAML yamllint 1 0 0.29s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@tyriis tyriis merged commit 6b353b7 into main Jan 31, 2025
16 checks passed
@tyriis tyriis deleted the feature/minecraft-public branch January 31, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants