-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(minecraft): disable rcon #4427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
--- kubernetes/talos-flux/apps/gaming-public/minecraft-java/velocity-proxy Kustomization: flux-system/minecraft-public-velocity-proxy HelmRelease: gaming-public/minecraft-public-velocity-proxy
+++ kubernetes/talos-flux/apps/gaming-public/minecraft-java/velocity-proxy Kustomization: flux-system/minecraft-public-velocity-proxy HelmRelease: gaming-public/minecraft-public-velocity-proxy
@@ -32,39 +32,33 @@
velocity:
annotations:
reloader.stakater.com/auto: 'true'
containers:
app:
env:
- ENABLE_RCON: 'true'
+ ENABLE_RCON: 'false'
GID: '1000'
MEMORY: 256M
PLUGINS: https://download.geysermc.org/v2/projects/geyser/versions/latest/builds/latest/downloads/velocity,https://download.geysermc.org/v2/projects/floodgate/versions/latest/builds/latest/downloads/velocity
SPIGOT_PLUGIN: '78915'
TYPE: VELOCITY
TZ: Europe/Vienna
UID: '1000'
VELOCITY_BUILD_ID: latest
VELOCITY_VERSION: latest
- envFrom:
- - secretRef:
- name: bungeecord-rcon
image:
repository: itzg/bungeecord
tag: latest@sha256:82b6a7b7d9aefbee26ce2c95e399d5e8dde073f5e6e87e6462f4016fca9f52f3
nameOverride: minecraft-public-velocity-proxy
ports:
- containerPort: 25565
name: velocity
protocol: TCP
- containerPort: 19132
name: bedrock
protocol: UDP
- - containerPort: 25575
- name: rcon
- protocol: TCP
probes:
liveness:
enabled: true
port: 25565
type: TCP
readiness:
@@ -115,19 +109,12 @@
type: persistentVolumeClaim
tmp:
globalMounts:
- path: /tmp
type: emptyDir
service:
- rcon:
- controller: velocity
- ports:
- rcon:
- port: 25575
- protocol: TCP
- targetPort: rcon
velocity:
annotations:
io.cilium/lb-ipam-ips: 192.168.1.86
controller: velocity
ports:
bedrock-proxy: |
--- HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy-rcon
+++ HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy-rcon
@@ -1,22 +0,0 @@
----
-apiVersion: v1
-kind: Service
-metadata:
- name: minecraft-public-velocity-proxy-rcon
- labels:
- app.kubernetes.io/instance: minecraft-public-velocity-proxy
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/name: minecraft-public-velocity-proxy
- app.kubernetes.io/service: minecraft-public-velocity-proxy-rcon
-spec:
- type: ClusterIP
- ports:
- - port: 25575
- targetPort: rcon
- protocol: TCP
- name: rcon
- selector:
- app.kubernetes.io/component: velocity
- app.kubernetes.io/instance: minecraft-public-velocity-proxy
- app.kubernetes.io/name: minecraft-public-velocity-proxy
-
--- HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy-velocity
+++ HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy-velocity
@@ -1,28 +0,0 @@
----
-apiVersion: v1
-kind: Service
-metadata:
- name: minecraft-public-velocity-proxy-velocity
- labels:
- app.kubernetes.io/instance: minecraft-public-velocity-proxy
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/name: minecraft-public-velocity-proxy
- app.kubernetes.io/service: minecraft-public-velocity-proxy-velocity
- annotations:
- io.cilium/lb-ipam-ips: 192.168.1.86
-spec:
- type: LoadBalancer
- ports:
- - port: 19132
- targetPort: bedrock
- protocol: UDP
- name: bedrock-proxy
- - port: 25565
- targetPort: velocity
- protocol: TCP
- name: velocity-proxy
- selector:
- app.kubernetes.io/component: velocity
- app.kubernetes.io/instance: minecraft-public-velocity-proxy
- app.kubernetes.io/name: minecraft-public-velocity-proxy
-
--- HelmRelease: gaming-public/minecraft-public-velocity-proxy Deployment: gaming-public/minecraft-public-velocity-proxy
+++ HelmRelease: gaming-public/minecraft-public-velocity-proxy Deployment: gaming-public/minecraft-public-velocity-proxy
@@ -41,13 +41,13 @@
hostNetwork: false
hostPID: false
dnsPolicy: ClusterFirst
containers:
- env:
- name: ENABLE_RCON
- value: 'true'
+ value: 'false'
- name: GID
value: '1000'
- name: MEMORY
value: 256M
- name: PLUGINS
value: https://download.geysermc.org/v2/projects/geyser/versions/latest/builds/latest/downloads/velocity,https://download.geysermc.org/v2/projects/floodgate/versions/latest/builds/latest/downloads/velocity
@@ -60,15 +60,12 @@
- name: UID
value: '1000'
- name: VELOCITY_BUILD_ID
value: latest
- name: VELOCITY_VERSION
value: latest
- envFrom:
- - secretRef:
- name: bungeecord-rcon
image: itzg/bungeecord:latest@sha256:82b6a7b7d9aefbee26ce2c95e399d5e8dde073f5e6e87e6462f4016fca9f52f3
livenessProbe:
failureThreshold: 3
initialDelaySeconds: 0
periodSeconds: 10
tcpSocket:
@@ -79,15 +76,12 @@
- containerPort: 25565
name: velocity
protocol: TCP
- containerPort: 19132
name: bedrock
protocol: UDP
- - containerPort: 25575
- name: rcon
- protocol: TCP
readinessProbe:
failureThreshold: 3
initialDelaySeconds: 0
periodSeconds: 10
tcpSocket:
port: 25565
--- HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy
+++ HelmRelease: gaming-public/minecraft-public-velocity-proxy Service: gaming-public/minecraft-public-velocity-proxy
@@ -0,0 +1,28 @@
+---
+apiVersion: v1
+kind: Service
+metadata:
+ name: minecraft-public-velocity-proxy
+ labels:
+ app.kubernetes.io/instance: minecraft-public-velocity-proxy
+ app.kubernetes.io/managed-by: Helm
+ app.kubernetes.io/name: minecraft-public-velocity-proxy
+ app.kubernetes.io/service: minecraft-public-velocity-proxy
+ annotations:
+ io.cilium/lb-ipam-ips: 192.168.1.86
+spec:
+ type: LoadBalancer
+ ports:
+ - port: 19132
+ targetPort: bedrock
+ protocol: UDP
+ name: bedrock-proxy
+ - port: 25565
+ targetPort: velocity
+ protocol: TCP
+ name: velocity-proxy
+ selector:
+ app.kubernetes.io/component: velocity
+ app.kubernetes.io/instance: minecraft-public-velocity-proxy
+ app.kubernetes.io/name: minecraft-public-velocity-proxy
+ |
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by OX Security |
jazzlyn
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.