Rework Citation Disambiguation #413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hayagriva's current disambiguation is incorrect: It adds names and given names even when they do not disambiguate the citation at all. If, for instance, we are only allowed to add initials, Hayagriva would produce "J. Doe 2025a; J. Doe 2025b" for two items from 2025 with authors "John Doe" and "Jane Doe". It should be "Doe 2025a; Doe 2025b", because the initials have no effect.
This PR makes the disambiguation (more) spec-compliant by following citeproc.
However, we are still incomplete: Only citations are disambiguated, not names generally. This is future work.
Makes 9 tests pass.