adding setting to store the reports

fixing #86
typemytype · Nov 19, 2024 · 98c9e28 · 98c9e28
1 parent 48b8706
commit 98c9e28
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/source/lib/batch.py b/source/lib/batch.py
@@ -247,19 +247,20 @@ def result(path):
                 for designspaceDocument in designspaceDocuments:
                     if shouldGenerateUFOsFromDesignspaces:
                         designspaceDocument.generateUFOs()
+
+                settings = getExtensionDefault("com.typemytype.batch.settings", defaultSettings)
+
                 try:
                     self.report = Report()
                     self.report.writeTitle("Batch Generate:")
                     self.report.indent()
-
-                    settings = getExtensionDefault("com.typemytype.batch.settings", defaultSettings)
-
                     for generator in generators:
                         generator.build(root, generateOptions, settings, progress, self.report)
 
                 finally:
                     self.report.dedent()
-                    self.report.save(os.path.join(root, "Batch Generate Report.txt"))
+                    if settings["batchSettingStoreReport"]:
+                        self.report.save(os.path.join(root, "Batch Generate Report.txt"))
                     self.report = None
                     progress.close()
 

diff --git a/source/lib/batchSettings.py b/source/lib/batchSettings.py
@@ -46,6 +46,7 @@
     batchSettingExportDebug=0,
     batchSettingExportInSubFolders=0,
     batchSettingExportKeepFileNames=0,
+    batchSettingStoreReport=1,
 
     desktopFontsAutohint=0,
     desktopFontsDecompose=1,
@@ -82,6 +83,13 @@
     webFontsSuffix="",
 )
 
+# update settings when new keys are added
+settings = getExtensionDefault("com.typemytype.batch.settings", dict())
+for key, value in defaultSettings.items():
+    if key not in settings:
+        settings[key] = value
+setExtensionDefault("com.typemytype.batch.settings", settings)
+
 
 class BatchSettingsController(ezui.WindowController):
 
@@ -153,6 +161,8 @@ def build(self, parent):
         > ( ) Use familyName-styleName        @batchSettingExportKeepFileNames
         > ( ) Keep file names
         > ---
+        > [ ] Store Export Report             @batchSettingStoreReport
+        > ---
         > [ ] Debug                           @batchSettingExportDebug
 
         =---=