Fix Field.get_attribute() return and RelatedField.to_representation() parameter for PKOnlyObject
#852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <[email protected]>
sobolevn
reviewed
Oct 15, 2025
Signed-off-by: Emmanuel Ferdman <[email protected]>
sobolevn
reviewed
Oct 15, 2025
Signed-off-by: Emmanuel Ferdman <[email protected]>
sobolevn
reviewed
Oct 17, 2025
Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: Emmanuel Ferdman <[email protected]>
intgr
requested changes
Oct 19, 2025
Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: Emmanuel Ferdman <[email protected]>
intgr
approved these changes
Oct 20, 2025
intgr
changed the title
Field.get_attribute stub signatureField.get_attribute() return and RelatedField.to_representation() parameter for PKOnlyObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adjusts the typing for relational serializer fields so they return the actual model instances or the lightweight
PKOnlyObjectDjango REST Framework sometimes uses, instead of the already-serialized values. This matches DRF’s real behavior:get_attributehandsto_representationeither the full object or the PK-only placeholder, so the new annotations describe exactly what callers receive and avoid type errors when the optimization kicks in.Fixes #829.