Fix class hierachy and TypeVars of Serializer classes #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
changed the title
* Remove unnecessary `Generic[]` where implicit TypeVars are sufficient. * `ModelSerializer` was incorrectly deriving from `Serializer[Any]` and `BaseSerializer`
intgr
force-pushed
the
fix-cleanup-serializer-typevars
branch
from
b51d616 to
9179c7d
Compare
|
Oops, I missed the notification that this got apprpoved. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made thunks!
ModelSerializerwas incorrectly deriving fromSerializer[Any]andBaseSerializer[T]; replaced withSerializer[T].This brings it into sync with DRF upstream.
Added TypeVar to
HyperlinkedModelSerializerclass.Removed unnecessary
Generic[]where implicit TypeVars are sufficient.https://mypy.readthedocs.io/en/stable/generics.html#defining-subclasses-of-generic-classes