Skip to content

5.0: Update django.db.models.expressions#2176

Merged
sobolevn merged 1 commit intotypeddjango:masterfrom
JaeHyuckSa:allow_default
May 21, 2024
Merged

5.0: Update django.db.models.expressions#2176
sobolevn merged 1 commit intotypeddjango:masterfrom
JaeHyuckSa:allow_default

Conversation

@JaeHyuckSa
Copy link
Copy Markdown
Contributor

@JaeHyuckSa JaeHyuckSa commented May 21, 2024

I have made things!

Update stubs for django.db.models.expressions for Django 5.0.

I moved all classes except F to the allowlist because their allowed_default is @cached_property method.

Related issues

Refs

Upstream PR

@JaeHyuckSa
Copy link
Copy Markdown
Contributor Author

JaeHyuckSa commented May 21, 2024

@sobolevn I know that there are many @cached_property methods in the allowlist. For ease of future work, is it okay to categorize all the @cached_property methods in the allowlist?

@sobolevn
Copy link
Copy Markdown
Member

sobolevn commented May 21, 2024

Yes :)

@sobolevn sobolevn merged commit 496190e into typeddjango:master May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JaeHyuckSa @sobolevn