-
Notifications
You must be signed in to change notification settings - Fork 67
content(typescript): use path mappings to simplify imports #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
content(typescript): use path mappings to simplify imports #21
Conversation
content(typescript): use path mappings to simplify imports
Hey Bo, Thanks for the submission! |
Hey @bovandersteene and @KwintenP, I agree that there are a few edge cases for when path mappings would make sense. It's quite delicate and for libraries I absolutely agree, e.g. for libraries that the Angular CLI or Nx create. But for just shortening paths in your application I think it's not a good idea to introduce math mappings. But then again, if you treat your folders inside your app as "libs" then it could make sense again. So I think it's not that clear when to use path mappings. But this is just my personal opinion. We can for sure discuss this. |
Hey @bovandersteene, what do you think about our comments and the comments from the community in the link @KwintenP posted? I am curious what you think about this and whether it makes sense to add such item to the checklist. |
This is what worries me a little in adding this item. I think it is quite hard to get that message out correctly so that everyone will properly get this. Do you think it is best not to add it in that case @bovandersteene and @d3lm? |
@bovandersteene @KwintenP I think this is a good practice and we should go forward with this PR. For Angular apps it makes sense to use path mappings, whereas for node it could cause some issues. I have also asked around on social media and most people agree that path mappings are / should be a best practice that projects should follow. |
@d3lm I think we should go forward with this |
content(typescript): use path mappings to simplify imports