fix(math): fix edge cases of ln and pow #533
Merged
+136
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly
previously approved these changes
Oct 28, 2024
There was a problem hiding this comment.
It's great we have more tests and better error handling on key functions. Commented with some suggestions, might be done in a later PR but given how important those low-level libraries are for the rest of the stack, we should delay for too long to provide strong correctness guarantees.
AndrewWestberg
force-pushed
the
529-the-natural-logarithm-of-a-0-fixeddecimal-should-not-be-0
branch
from
4d879da to
96380bc
Compare
AndrewWestberg
force-pushed
the
529-the-natural-logarithm-of-a-0-fixeddecimal-should-not-be-0
branch
from
96380bc to
4f78f8c
Compare
AndrewWestberg
requested review from
scarmuega
and removed request for
scarmuega
|
Not mandatory, but since Rust 1.80, the |
scarmuega
approved these changes
Oct 31, 2024
AndrewWestberg
deleted the
529-the-natural-logarithm-of-a-0-fixeddecimal-should-not-be-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we shouldn't hit these cases in doing math for cardano, it's a good practice to add them to the math library in case they are needed for the future.