Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: final protocol param update not being applied #422

Closed
wants to merge 2 commits into from

Conversation

ricomiles
Copy link
Contributor

@ricomiles ricomiles commented Dec 30, 2024

This fixes a bug where the last two protocol parameter updates aren't being applied. The issue arises because the epoch for-loop does not include the last two updates due to how the filtering of the updates works.
This also fixes protocol version param not updating

@ricomiles ricomiles requested a review from scarmuega as a code owner December 30, 2024 20:25
@scarmuega
Copy link
Member

@ricomiles are we sure this is the correct behavior?
if this is the fix, then the problem should only appear when you're evaluating the updates in the exact same epoch as when they were submitted. Is that what's happening?

@ricomiles ricomiles closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants