(2FA) Add option to grab all mails instead of searching index#169
Open
kaffetorsk wants to merge 4 commits intotwrecked:masterfrom
Open
(2FA) Add option to grab all mails instead of searching index#169kaffetorsk wants to merge 4 commits intotwrecked:masterfrom
kaffetorsk wants to merge 4 commits intotwrecked:masterfrom
Conversation
Owner
|
I'd been meaning to take a look at this but work has been crazy busy. I'll take a look this week, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find that some imap providers are slow to index, and that 2fa fails due to this.
This PR adds an option to grab all mails in the inbox and filter them locally, as to avoid the indexing problem.
Also added an option to delete the 2fa-mail after retrieving the code.
It's working well with my provider, and since the options are by default turned off it's fully backward compatible.