Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update pruneEmptyDicts reference docs #4218

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

FoolsTech
Copy link

@FoolsTech FoolsTech commented Jan 21, 2025

Docs: fix 'function "inner" not defined' in pruneEmptyDicts example

Copy link
Collaborator

@halostatue halostatue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to change your commit message and PR title to match our conventions. The prefix you would use is docs:.

The commit messages follow the conventional commits specification. chezmoi's release notes are generated directly from the commit messages. For trivial or user-invisible changes, please use the prefix chore:.

Contributing changes

@FoolsTech
Copy link
Author

Ah, ok, sorry. Thanx for the info.

@FoolsTech FoolsTech changed the title Update pruneEmptyDicts reference docs Docs: Update pruneEmptyDicts reference docs Jan 22, 2025
@halostatue
Copy link
Collaborator

Sorry; you need to fix both the commit title and the PR title.

The following command should fix this on your local clone of twpayne/chezmoi and push it up for review:

git commit --amend -m 'docs: Update pruneEmptyDicts example

Fix 'function "inner" not found' in pruneEmptyDicts example.
'
git push --force-with-lease

@FoolsTech
Copy link
Author

Cool, thanx!

@bradenhilton
Copy link
Collaborator

@FoolsTech the prefix needs to be lowercase (docs: instead of Docs:)

Fix 'function "inner" not found' in prneEmptyDicts example
@FoolsTech
Copy link
Author

@halostatue
oh man, so sorry

@halostatue halostatue changed the title Docs: Update pruneEmptyDicts reference docs docs: Update pruneEmptyDicts reference docs Jan 23, 2025
@halostatue halostatue merged commit 70546ad into twpayne:master Jan 23, 2025
23 checks passed
@bradenhilton
Copy link
Collaborator

Thanks for the fix @FoolsTech!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants