Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass the --needed flag to pacman #3651

Merged
merged 1 commit into from
Mar 17, 2024
Merged

fix: pass the --needed flag to pacman #3651

merged 1 commit into from
Mar 17, 2024

Conversation

aarondill
Copy link
Contributor

This ensures that pacman doesn't re-install an already up-to-date package

This ensures that pacman doesn't re-install an already up-to-date package
Copy link
Collaborator

@halostatue halostatue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description covers what this does nicely, but I don't use Arch to be able to test this myself.

@aarondill
Copy link
Contributor Author

aarondill commented Mar 16, 2024

here's a quote from the arch wiki describing the flag.

Note: If a package in the list is already installed on the system, it will be reinstalled even if it is already up-to-date. This behavior can be overridden with the --needed option.

with this change, chezmoi will still invoke pacman when the package is out of date with the github releases (it usually is), but pacman will just warn the user that the package is already up to date with the arch repos and do nothing

@twpayne twpayne merged commit f490429 into twpayne:master Mar 17, 2024
21 checks passed
@twpayne
Copy link
Owner

twpayne commented Mar 17, 2024

Thank you very much!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants