kgo: fix race condition in ProduceSync #920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProduceSync promise can be called from several goroutine at the same time making the append() unsafe.
daedric
force-pushed
the
ts/fix/race-sync-produce
branch
from
0d1c9f6 to
018d89b
Compare
|
Luckily not a race; Produce finishes all promises in order in a dedicated goroutine Line 573 in f30c518 |
|
Oh thanks, that was subtle :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the code I stumbled upon a potential race condition.
Here is my suggestion for a fix.