add the kvictoria plug-in to provide metrics #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a plug-in to provide metrics using the VictoriaMetrics/metrics library as discussed in #875
It's based on the
kpromplug-in although I decided to not provide any option other than the possibility to set the subsystem: in my experience, every metrics available in the hooks are useful and I see no point in not including them (and if a user doesn't want some metrics they can drop them during scraping).There's no change needed in
kgobut like I mentioned in #875, the PR #820 will be useful for this plug-in too because I'll be able to use the client id in more metrics; right now I can only use the client id in the various gauges tracking what's buffered.I tested this locally with a small test program, a VictoriaMetrics instance that scrape it and a grafana dashboard to see if the metrics make sense. I can provide that if needed; as far as I can tell everything looks good.
Let me know if you have any question.