Skip to content

Commit

Permalink
workflows: disable linting, add next gen config opt
Browse files Browse the repository at this point in the history
Linting on GH is currently broken.
  • Loading branch information
twmb committed Feb 20, 2025
1 parent d918585 commit 4cb5c92
Showing 1 changed file with 15 additions and 13 deletions.
28 changes: 15 additions & 13 deletions .github/workflows/lint-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,20 @@ concurrency:
cancel-in-progress: true

jobs:
golangci:
if: github.repository == 'twmb/franz-go'
runs-on: ubuntu-latest
name: "golangci-lint on amd64"
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 'stable'
- uses: golangci/golangci-lint-action@v6
with:
version: latest
args: --timeout=5m
# Currently broken. Running these locally.
#golangci:
# if: github.repository == 'twmb/franz-go'
# runs-on: ubuntu-latest
# name: "golangci-lint on amd64"
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-go@v5
# with:
# go-version: 'stable'
# - uses: golangci/golangci-lint-action@v6
# with:
# version: latest
# args: --timeout=5m

test-kfake:
if: github.repository == 'twmb/franz-go'
Expand Down Expand Up @@ -58,6 +59,7 @@ jobs:
KAFKA_CFG_TRANSACTION_PARTITION_VERIFICATION_ENABLE: false
# Set this to "PLAINTEXT://127.0.0.1:9092" if you want to run this container on localhost via Docker
KAFKA_CFG_ADVERTISED_LISTENERS: PLAINTEXT://kafka:9092
KAFKA_CFG_GROUP_COORDINATOR_REBALANCE_PROTOCOLS: classic,consumer
KAFKA_CFG_NODE_ID: 1
ALLOW_PLAINTEXT_LISTENER: yes
KAFKA_KRAFT_CLUSTER_ID: XkpGZQ27R3eTl3OdTm2LYA # 16 byte base64-encoded UUID
Expand Down

0 comments on commit 4cb5c92

Please sign in to comment.