Skip to content

Commit

Permalink
Put Codecov in informational mode
Browse files Browse the repository at this point in the history
Automatically rejecting PRs on dropping coverage doesn't work well
in practice, because there are situations in which coverage drops
while code improves. For example removing code that had test coverage
but is no longer needed will lower total coverage, while removing
dead code can lead to low diff coverage.

With this change, it is up to reviewers to check whether a dropping
coverage is a cause for concern (missing test cases for new/changed
functionality) or expected.
  • Loading branch information
mthuurne committed Dec 11, 2019
1 parent 8a89368 commit 09cafd7
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions .codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
coverage:
status:
project:
default:
informational: true
patch:
default:
informational: true

0 comments on commit 09cafd7

Please sign in to comment.