Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: convert operationPromise .then calls to async/await syntax #1072

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tawsifkamal
Copy link

Fixes

  • Converts the operationPromise defined in all class methods to use the .then syntax to use async/await syntax
  • Adds Try/Catch in the function body itself instead the callback being passed into setPromiseCallback
  • Creates the change using a codemod
  • Changes all 591 instances across the class methods. However, this change does not touch the instances in top-level functions. This can be pursued if desired.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

No new tests required for the changes. Ran make test and all tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant