fix!: Represent prices as decimal values #758
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
The Twilio API actually returns prices as strings, but the Java SDK represents them as
double
values. Generally, it's best to avoid floating-point representations of monetary values, and it appears that the API itself is designed with this in mind.This pull request:
double
toBigDecimal
. The existing getters are unchanged and return adouble
representation of the prices. I've added new getters (e.g.getBasePriceDecimal
) that return the prices as lossless decimal values.The second change should be backward-compatible for most users, but I believe this is still technically a breaking change because it changes the constructors of those objects. Still, with the 10-series SDK going out, this may be a good time to make the change.
Checklist
I have added the necessary documentation about the functionality in the appropriate .md file(n/a)