-
Notifications
You must be signed in to change notification settings - Fork 33
Add ability to set input stream #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamduren
wants to merge
1
commit into
twilio:master
Choose a base branch
from
LiftAI:input-audio-stream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -317,6 +317,15 @@ class AudioHelper extends EventEmitter { | |
'Related BugZilla thread: https://bugzilla.mozilla.org/show_bug.cgi?id=1299324')); | ||
} | ||
|
||
/** | ||
* Replace the current input steamd with a new MediaStream. | ||
* @param stream - A media stream to use as input | ||
* @param device - A device to use as input | ||
*/ | ||
setInputStream(stream: MediaStream, device: MediaDeviceInfo | null): Promise<void> { | ||
return this._setInputStream(stream, device); | ||
} | ||
|
||
/** | ||
* Unset the MediaTrackConstraints to be applied on every getUserMedia call for new input | ||
* device audio. The returned Promise resolves when the media is successfully reacquired, | ||
|
@@ -487,14 +496,23 @@ class AudioHelper extends EventEmitter { | |
|
||
const constraints = { audio: Object.assign({ deviceId: { exact: deviceId } }, this.audioConstraints) }; | ||
return this._getUserMedia(constraints).then((stream: MediaStream) => { | ||
return this._onActiveInputChanged(stream).then(() => { | ||
this._replaceStream(stream); | ||
this._inputDevice = device; | ||
this._maybeStartPollingVolume(); | ||
}); | ||
return this._setInputStream(stream, device); | ||
}); | ||
} | ||
|
||
/** | ||
* Replace the current input steamd with a new MediaStream. | ||
* @param stream - A media stream to use as input | ||
* @param device - A device to use as input | ||
*/ | ||
private _setInputStream(stream: MediaStream, device: MediaDeviceInfo | null): Promise<void> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like we could nix the private method and put this logic in the public |
||
return this._onActiveInputChanged(stream).then(() => { | ||
this._replaceStream(stream); | ||
this._inputDevice = device; | ||
this._maybeStartPollingVolume(); | ||
}); | ||
} | ||
|
||
/** | ||
* Update the available input and output devices | ||
*/ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sp: steamd -> stream