Skip to content

Chore/yarn3 #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 22, 2021
Merged

Chore/yarn3 #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
23e58f2
chore(yarn3): run yarn migration
Oct 8, 2021
351331a
chore(yarn3): yarn3 update, gitignore update
Oct 9, 2021
9da5c25
chore(yarn3): update scripts to account for lack of prescript hooks
Oct 11, 2021
0201172
chore(yarn3): lock eslint related deps, add eslintignore rules
zahnster Oct 12, 2021
1b73a48
chore(yarn3): remove glob in lint script so lint gets the right files
zahnster Oct 14, 2021
485e58f
chore(yarn3): update netlify-cli and add to projects, remove old script
Oct 14, 2021
4742974
chore(yarn3): update deprecated yarn flag
Oct 14, 2021
faf8f11
chore: try some caching and limiting workspaces
SiTaggart Oct 15, 2021
cfb90dc
chore: netlify build from config, get cypress running
SiTaggart Oct 15, 2021
1482033
chore: replace lerna requirement in scripts
SiTaggart Oct 15, 2021
c8897a2
chore(yarn3): add form package to modal
zahnster Oct 16, 2021
cd75770
chore(yarn3): yarn3 cleanup
zahnster Oct 16, 2021
1f5697b
chore(yarn3): placeholder bootstrap command
zahnster Oct 18, 2021
9fca9d2
chore(yarn3): use fork of compressed-size-action
Oct 21, 2021
c1e9945
chore(yarn3): revert back to lerna for perf
Oct 21, 2021
54689c9
chore(yarn3): empty bootstrap
Oct 21, 2021
77502f2
fix: try unsetting the yarn version in config
SiTaggart Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,7 @@ packages/paste-token-contrast-checker/public
.next
.yarn

packages/**/dist/*

tsconfig.build.tsbuildinfo
**/*.d.ts
10 changes: 0 additions & 10 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,4 @@ module.exports = {
// We don't use jasmine and this clashes with danger js
'jest/no-jasmine-globals': 'off',
},
settings: {
'import/resolver': {
[path.join(__dirname, './.eslint/resolver')]: {
someConfig: '',
},
node: {
extensions: ['.js', '.jsx', '.ts', '.tsx', '.d.ts'],
},
},
},
};
15 changes: 8 additions & 7 deletions .github/workflows/cypress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,21 @@ jobs:
with:
node-version: 12.x

- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Get yarn cache directory path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer cache syntax

id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"

- uses: actions/cache@v2
name: Load Yarn cache
- name: Load Yarn cache
uses: actions/cache@v2
id: yarn_cache_id
with:
path: ${{ steps.yarn-cache.outputs.dir }}
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn

- name: Install Dependencies
run: yarn install --frozen-lockfile && yarn bootstrap
run: yarn install --immutable

- name: Build packages
run: yarn build
Expand Down
14 changes: 13 additions & 1 deletion .github/workflows/package-size.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,19 @@ jobs:
with:
node-version: 12.x

- uses: preactjs/compressed-size-action@v2
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"

- name: Load Yarn cache
uses: actions/cache@v2
id: yarn_cache_id
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn
- uses: zahnster/[email protected]
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
build-script: "build:js"
Expand Down
15 changes: 8 additions & 7 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,21 @@ jobs:
with:
node-version: 12.x

- id: yarn-cache
name: Get Yarn cache path
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"

- uses: actions/cache@v2
name: Load Yarn cache
- name: Load Yarn cache
uses: actions/cache@v2
id: yarn_cache_id
with:
path: ${{ steps.yarn-cache.outputs.dir }}
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn

- name: Install Dependencies
run: yarn install --frozen-lockfile && yarn bootstrap
run: yarn install --immutable

- name: Setup CI Git User
run: |
Expand Down
64 changes: 25 additions & 39 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ jobs:
with:
node-version: 12.x

- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"

- name: Load Yarn cache
uses: actions/cache@v2
id: yarn_cache_id
with:
path: ${{ steps.yarn-cache.outputs.dir }}
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn
Expand All @@ -38,10 +38,7 @@ jobs:

- name: Install Dependencies
if: steps.yarn_cache_id.outputs.cache-hit != 'true' || steps.node_modules_cache_id.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- name: Bootstrap lerna
run: yarn bootstrap
run: yarn install --immutable

- name: Build packages
run: yarn build
Expand All @@ -60,15 +57,15 @@ jobs:
with:
node-version: 12.x

- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"

- name: Load Yarn cache
uses: actions/cache@v2
id: yarn_cache_id
with:
path: ${{ steps.yarn-cache.outputs.dir }}
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn
Expand All @@ -84,10 +81,7 @@ jobs:

- name: Install Dependencies
if: steps.yarn_cache_id.outputs.cache-hit != 'true' || steps.node_modules_cache_id.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- name: Bootstrap lerna
run: yarn bootstrap
run: yarn install --immutable

- name: Build packages
run: yarn build
Expand All @@ -106,15 +100,15 @@ jobs:
with:
node-version: 12.x

- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"

- name: Load Yarn cache
uses: actions/cache@v2
id: yarn_cache_id
with:
path: ${{ steps.yarn-cache.outputs.dir }}
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn
Expand All @@ -130,10 +124,7 @@ jobs:

- name: Install Dependencies
if: steps.yarn_cache_id.outputs.cache-hit != 'true' || steps.node_modules_cache_id.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- name: Bootstrap lerna
run: yarn bootstrap
run: yarn install --immutable

- name: Build packages
run: yarn build
Expand All @@ -152,15 +143,15 @@ jobs:
with:
node-version: 12.x

- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"

- name: Load Yarn cache
uses: actions/cache@v2
id: yarn_cache_id
with:
path: ${{ steps.yarn-cache.outputs.dir }}
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn
Expand All @@ -176,10 +167,7 @@ jobs:

- name: Install Dependencies
if: steps.yarn_cache_id.outputs.cache-hit != 'true' || steps.node_modules_cache_id.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- name: Bootstrap lerna
run: yarn bootstrap
run: yarn install --immutable

- name: Build packages
run: yarn build
Expand All @@ -196,14 +184,14 @@ jobs:
uses: actions/setup-node@v2
with:
node-version: 12.x
- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
- name: Load Yarn cache
uses: actions/cache@v2
id: yarn_cache_id
with:
path: ${{ steps.yarn-cache.outputs.dir }}
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn
Expand All @@ -217,9 +205,7 @@ jobs:
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- name: Install Dependencies
if: steps.yarn_cache_id.outputs.cache-hit != 'true' || steps.node_modules_cache_id.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile
- name: Bootstrap lerna
run: yarn bootstrap
run: yarn install --immutable
- name: Run DangerJS
run: yarn danger ci
env:
Expand Down
13 changes: 5 additions & 8 deletions .github/workflows/vrt_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ jobs:
with:
node-version: 12.x

- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"

- name: Load Yarn cache
uses: actions/cache@v2
id: yarn_cache_id
with:
path: ${{ steps.yarn-cache.outputs.dir }}
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn
Expand All @@ -47,10 +47,7 @@ jobs:

- name: Install Dependencies
if: steps.yarn_cache_id.outputs.cache-hit != 'true' || steps.node_modules_cache_id.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile && yarn bootstrap

- name: Bootstrap lerna
run: yarn bootstrap
run: yarn install --immutable

- name: Build packages
run: yarn build
Expand Down
13 changes: 5 additions & 8 deletions .github/workflows/vrt_pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ jobs:
with:
node-version: 12.x

- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"

- name: Load Yarn cache
uses: actions/cache@v2
id: yarn_cache_id
with:
path: ${{ steps.yarn-cache.outputs.dir }}
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn
Expand All @@ -44,10 +44,7 @@ jobs:

- name: Install Dependencies
if: steps.yarn_cache_id.outputs.cache-hit != 'true' || steps.node_modules_cache_id.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile && yarn bootstrap

- name: Bootstrap lerna
run: yarn bootstrap
run: yarn install --immutable

- name: Build packages
run: yarn build
Expand Down
9 changes: 9 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,12 @@ cypress/screenshots

# Local Netlify folder
.netlify

# Yarn Folders
.pnp.*
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions
Loading