Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model)!: incoming heartbeat has null data #2420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vilgotf
Copy link
Member

@vilgotf vilgotf commented Feb 15, 2025

My shard received a heartbeat event and apparently we model that wrongly. Discord documents this event as containing data, but that's only when sent to the gateway.

2025-02-14T15:50:16.796316Z DEBUG twilight_gateway::shard: received heartbeat
2025-02-14T15:50:16.796359Z  WARN gateway_request_members: error receiving event source=ReceiveMessageError { kind: Deserializing { event: "{\"t\":null,\"s\":null,\"op\":1,\"d\":null}" }, source: Some(Error("invalid type: null, expected u64", line: 1, column: 34)) }

@vilgotf vilgotf marked this pull request as ready for review February 15, 2025 08:47
@github-actions github-actions bot added c-cache Affects the cache crate c-model Affects the model crate t-fix Fixes a bug in the library labels Feb 15, 2025
@Erk-
Copy link
Member

Erk- commented Feb 18, 2025

Going to change the name to include a ! since we want to mark this as a breaking change in the change log.

@Erk- Erk- changed the title fix(model): incoming heartbeat has null data fix(model)!: incoming heartbeat has null data Feb 18, 2025
@github-actions github-actions bot added the m-breaking change Breaks the public API. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-cache Affects the cache crate c-model Affects the model crate m-breaking change Breaks the public API. t-fix Fixes a bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants