refacto(invite|signin): remove unused code + fix signin on invite page. #9745

AMoreaux · 2025-01-20T14:34:40Z

Replace window.location.replace by useRedirect hook.
Remove unused code: switchWorkspace, addUserByInviteHash...
Refacto Invite component.
Fix signin on invite modal.

…ode-and-fix-signin-on-invite-page

Eliminates the SwitchWorkspace functionality, including its service, DTO, and related resolver logic. This cleanup removes unused code and simplifies the auth module structure.

Removed the `switchWorkspace` mutation and its associated arguments from the GraphQL schema. This code was unused and its removal helps in cleaning up the generated types and mutations.

Introduced the `timeoutSeconds` field in various types and mutations related to ServerlessFunction. This allows setting a timeout for serverless functions, providing more configurability for function execution limits.

…nvite-page

Removed obsolete mutations and related logic for adding users to workspaces via invite tokens or hashes. Replaced old `window.location.replace` calls with the `redirect` hook across affected files to improve maintainability and consistency.

…-signin-on-invite-page' into chore/remove-unused-code-and-fix-signin-on-invite-page

…nvite-page

Removed unused `workspacePublicData` from `useSignInUp` hook and cleaned up a debug log in SettingsDomain. These changes improve code readability and maintainability by eliminating unnecessary code.

greptile-apps

PR Summary

This PR significantly refactors authentication and workspace management, focusing on cleaning up unused code and improving the sign-in flow for invited users.

Removes switchWorkspace mutation and related services/tests, replacing direct workspace switching with useRedirect hook for navigation
Removes unused workspace invitation mutations (addUserToWorkspace, addUserToWorkspaceByInviteToken) and consolidates invite handling in sign-in flow
Fixes password validation in validatePassword method by removing redundant password hashing
Simplifies Invite component by removing complex workspace switching logic and relying on SignInUpWorkspaceScopeForm
Makes subdomain parameter required in buildWorkspaceUrl function and adds it to workspace invite hash query

_{28 file(s) reviewed, 7 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-01-20T17:03:11Z

packages/twenty-front/src/modules/domain-manager/hooks/useBuildWorkspaceUrl.ts

@@ -6,13 +6,13 @@ export const useBuildWorkspaceUrl = () => {
  const domainConfiguration = useRecoilValue(domainConfigurationState);

  const buildWorkspaceUrl = (
-    subdomain?: string,
+    subdomain: string,


logic: Making subdomain required could break existing code that passes undefined. Consider keeping it optional or documenting the breaking change.

greptile-apps · 2025-01-20T17:03:12Z

packages/twenty-front/src/modules/domain-manager/hooks/useBuildWorkspaceUrl.ts

+    if (subdomain.length !== 0) {
      url.hostname = `${subdomain}.${domainConfiguration.frontDomain}`;
    }


style: Consider handling invalid/malformed subdomains to prevent invalid URLs

greptile-apps · 2025-01-20T17:04:00Z

...ront/src/modules/ui/navigation/navigation-drawer/components/MultiWorkspaceDropdownButton.tsx

+  const handleChange = async (workspace: Workspaces[0]) => {
+    redirectToWorkspaceDomain(workspace.subdomain);
  };


logic: handleChange is now async but doesn't await the redirect call

greptile-apps · 2025-01-20T17:04:07Z

...ages/twenty-front/src/modules/ui/navigation/navigation-drawer/hooks/useWorkspaceSwitching.ts

logic: Removing this hook could break workspace switching functionality in other components that depend on it, particularly MultiWorkspaceDropdownButton.tsx which is also modified in this PR. Verify that all consumers of this hook have been properly updated to use alternative methods.

greptile-apps · 2025-01-20T17:04:07Z

...ages/twenty-front/src/modules/ui/navigation/navigation-drawer/hooks/useWorkspaceSwitching.ts

style: The removed code handled error cases and showed error messages to users. Ensure the new implementation has proper error handling and user feedback mechanisms.

greptile-apps · 2025-01-20T17:06:06Z

packages/twenty-server/src/engine/core-modules/auth/dto/switch-workspace.input.ts

logic: Removing this DTO could break GraphQL operations that depend on it. Verify that all references to SwitchWorkspaceInput in auth.resolver.ts and other resolvers have been properly updated or removed.

greptile-apps · 2025-01-20T17:06:36Z

packages/twenty-server/src/engine/core-modules/auth/services/switch-workspace.service.ts

logic: Removing this service eliminates critical workspace access validation. Verify this logic exists elsewhere to prevent unauthorized workspace access.

Cleaned up unused `useRecoilValue` and related state to simplify and optimize imports in `useSignInUp`. This enhances maintainability by reducing unnecessary code.

…ode-and-fix-signin-on-invite-page

charlesBochet · 2025-01-21T15:08:59Z

packages/twenty-front/src/modules/auth/states/workspaces.ts


-export const workspacesState = createState<Workspaces[] | null>({
+export const workspacesState = createState<Workspaces | null>({


remove | null

Introduce `publicFeatureFlags` and `PublicFeatureFlag` types to GraphQL schema. Added `updateLabPublicFeatureFlag` mutation and its input type, while removing `addUserToWorkspace` and `addUserToWorkspaceByInviteToken` mutations. Also adjusted enum casing for `WorkspaceActivationStatus` for consistency.

Changed the default value of workspacesState from null to an empty array to ensure proper handling of workspaces initialization. This prevents potential null-related errors in dependent components.

fix(apollo): handle empty workspaces state correctly Replaced null with an empty array for workspaces to ensure consistent state handling. Updated the logic that checks for multiple workspaces to align with the new change. This prevents potential errors when working with workspace data. ```

github-actions · 2025-01-21T15:34:26Z

	Fails
🚫	`node` failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-a993bb2e.json

Generated by 🚫 dangerJS against c74a19f

AMoreaux added 2 commits January 20, 2025 14:43

WIP

f907774

remove unused code

ac80646

AMoreaux self-assigned this Jan 20, 2025

AMoreaux added 7 commits January 20, 2025 15:35

Merge remote-tracking branch 'origin/main' into chore/remove-unused-c…

3641c30

…ode-and-fix-signin-on-invite-page

refactor(auth): remove SwitchWorkspace feature

501d5a8

Eliminates the SwitchWorkspace functionality, including its service, DTO, and related resolver logic. This cleanup removes unused code and simplifies the auth module structure.

refactor(graphql): remove unused switchWorkspace mutation

bbd4a21

Removed the `switchWorkspace` mutation and its associated arguments from the GraphQL schema. This code was unused and its removal helps in cleaning up the generated types and mutations.

feat(graphql): add timeoutSeconds field to ServerlessFunction

d153a49

Introduced the `timeoutSeconds` field in various types and mutations related to ServerlessFunction. This allows setting a timeout for serverless functions, providing more configurability for function execution limits.

Merge branch 'main' into chore/remove-unused-code-and-fix-signin-on-i…

4a7c653

…nvite-page

Merge remote-tracking branch 'origin/chore/remove-unused-code-and-fix…

6803ed7

…-signin-on-invite-page' into chore/remove-unused-code-and-fix-signin-on-invite-page

AMoreaux requested a review from Weiko January 20, 2025 16:51

AMoreaux added 2 commits January 20, 2025 17:51

Merge branch 'main' into chore/remove-unused-code-and-fix-signin-on-i…

5f50e05

…nvite-page

refactor(auth, settings): remove unused state and debug log

201f9a5

Removed unused `workspacePublicData` from `useSignInUp` hook and cleaned up a debug log in SettingsDomain. These changes improve code readability and maintainability by eliminating unnecessary code.

AMoreaux marked this pull request as ready for review January 20, 2025 17:00

greptile-apps bot reviewed Jan 20, 2025

View reviewed changes

AMoreaux added 3 commits January 20, 2025 18:19

refactor(auth): remove unused Recoil dependency

9605bfb

Cleaned up unused `useRecoilValue` and related state to simplify and optimize imports in `useSignInUp`. This enhances maintainability by reducing unnecessary code.

Merge remote-tracking branch 'origin/main' into chore/remove-unused-c…

e71c7c0

…ode-and-fix-signin-on-invite-page

Merge remote-tracking branch 'origin/main' into chore/remove-unused-c…

6da29f1

…ode-and-fix-signin-on-invite-page

charlesBochet approved these changes Jan 21, 2025

View reviewed changes

AMoreaux added 3 commits January 21, 2025 16:14

fix(auth): update workspacesState default value type

29531d1

Changed the default value of workspacesState from null to an empty array to ensure proper handling of workspaces initialization. This prevents potential null-related errors in dependent components.

charlesBochet merged commit 34afd73 into main Jan 21, 2025
47 checks passed

charlesBochet deleted the chore/remove-unused-code-and-fix-signin-on-invite-page branch January 21, 2025 15:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refacto(invite|signin): remove unused code + fix signin on invite page. #9745

refacto(invite|signin): remove unused code + fix signin on invite page. #9745

AMoreaux commented Jan 20, 2025 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Jan 20, 2025

greptile-apps bot Jan 20, 2025

greptile-apps bot Jan 20, 2025

greptile-apps bot Jan 20, 2025

greptile-apps bot Jan 20, 2025

greptile-apps bot Jan 20, 2025

greptile-apps bot Jan 20, 2025

charlesBochet Jan 21, 2025

github-actions bot commented Jan 21, 2025


		export const workspacesState = createState<Workspaces[] \| null>({
		export const workspacesState = createState<Workspaces \| null>({

refacto(invite|signin): remove unused code + fix signin on invite page. #9745

refacto(invite|signin): remove unused code + fix signin on invite page. #9745

Conversation

AMoreaux commented Jan 20, 2025 • edited Loading

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Jan 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 20, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 20, 2025

Choose a reason for hiding this comment

charlesBochet Jan 21, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 21, 2025

Log

AMoreaux commented Jan 20, 2025 •

edited

Loading