[test(auth)]: Add unit tests for useSignInUpForm hook #9648
+68
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce unit tests to validate the behavior of the useSignInUpForm hook. Tests cover default initialization, handling of developer defaults, and prefilled values based on state.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added comprehensive unit tests for the useSignInUpForm hook, validating form initialization and state-dependent prefill behavior in the authentication flow.
- Added test cases in
/packages/twenty-front/src/modules/auth/sign-in-up/hooks/__tests__/useSignInUpForm.test.tsxfor form initialization and developer default prefilling - Tests verify correct handling of URL email parameters and developer prefill state
- Hardcoded password 'Applecar2025' in tests should be moved to a test constants file
- Commented-out test case for prefilled email functionality should be implemented
- Missing test coverage for password validation using PASSWORD_REGEX
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| </MemoryRouter> | ||
| ), | ||
| }); | ||
| expect(result.current.form).toBeDefined(); |
There was a problem hiding this comment.
logic: This assertion only checks if form exists. Should verify the actual default values.
Comment on lines
24
to
27
| // it('should set prefilled email if available', () => { | ||
| // renderHook(() => useSignInUpForm()); | ||
| // expect(mockSetValue).toHaveBeenCalledWith('email', mockPrefilledEmail); | ||
| // }); |
There was a problem hiding this comment.
style: Incomplete test case left commented out. Either implement or remove.
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('should initialize the form with default values', async () => { |
There was a problem hiding this comment.
logic: Test is marked async but doesn't use any await statements
Introduce unit tests to validate the behavior of the useSignInUpForm hook. Tests cover default initialization, handling of developer defaults, and prefilled values based on state.
Weiko
approved these changes
Jan 15, 2025
Log |
pacyL2K19
pushed a commit
to pacyL2K19/twenty
that referenced
this pull request
Jan 16, 2025
Introduce unit tests to validate the behavior of the useSignInUpForm hook. Tests cover default initialization, handling of developer defaults, and prefilled values based on state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce unit tests to validate the behavior of the useSignInUpForm hook. Tests cover default initialization, handling of developer defaults, and prefilled values based on state.