Outlook integration #9631
Merged
Outlook integration #9631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented Microsoft Outlook integration for email syncing, adding support for delta-based message synchronization and proper error handling for sync cursor operations.
- Added
SYNC_CURSOR_ERRORhandling inmessage-import-driver.exception.tsfor Microsoft-specific sync issues - Implemented
getPartialMessageListinmicrosoft-get-message-list.service.tswith delta API support for incremental syncing - Added upsert operation in
messaging-message.service.tsto prevent duplicate message entries - Added comprehensive Microsoft 365 setup documentation with required API permissions and license requirements
- Updated
MicrosoftAPIsServiceto handle message channel sync states and queue message fetching jobs
8 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
...age-import-manager/drivers/microsoft/services/microsoft-get-message-list.service.dev.spec.ts
Show resolved
Hide resolved
...age-import-manager/drivers/microsoft/services/microsoft-get-message-list.service.dev.spec.ts
Show resolved
Hide resolved
...ging/message-import-manager/drivers/microsoft/services/microsoft-get-message-list.service.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/microsoft-apis.service.ts
Show resolved
Hide resolved
Comment on lines
+189
to
+195
| await this.messageQueueService.add<MessagingMessageListFetchJobData>( | ||
| MessagingMessageListFetchJob.name, | ||
| { | ||
| workspaceId, | ||
| messageChannelId: messageChannel.id, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
style: These message queue jobs are not awaited in parallel which could be slow for multiple channels. Consider using Promise.all().
...odules/messaging/message-import-manager/services/message-import-exception-handler.service.ts
Show resolved
Hide resolved
Comment on lines
+169
to
+172
| workspaceId: string, | ||
| ): Promise<void> { | ||
| await this.messageChannelSyncStatusService.markAsFailedUnknownAndFlushMessagesToImport( | ||
| [messageChannel.id], |
There was a problem hiding this comment.
logic: This re-throws the same exception type that was caught. Consider throwing MessageImportException instead to be consistent with handleUnknownException pattern
...odules/messaging/message-import-manager/services/message-import-exception-handler.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/microsoft-apis.service.ts
Outdated
Show resolved
Hide resolved
...es/messaging/message-import-manager/drivers/gmail/services/gmail-get-message-list.service.ts
Outdated
Show resolved
Hide resolved
...odules/messaging/message-import-manager/services/message-import-exception-handler.service.ts
Outdated
Show resolved
Hide resolved
...odules/messaging/message-import-manager/services/message-import-exception-handler.service.ts
Show resolved
Hide resolved
...odules/messaging/message-import-manager/services/message-import-exception-handler.service.ts
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get Partial messages