Add field isLabelSyncedWithName #8829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a new boolean field isLabelSyncedWithName to control synchronization between field labels and API names, particularly for enum naming patterns.
- Added
isLabelSyncedWithNamecolumn tometadata.fieldMetadatatable with default valuetruein/packages/twenty-server/src/database/typeorm/metadata/migrations/1733072126592-addIsLabelSyncedWithNameToFieldMetadata.ts - Added advanced settings section with API Name input and sync toggle in
/packages/twenty-front/src/modules/settings/data-model/fields/forms/components/SettingsDataModelFieldIconLabelForm.tsx - Modified workspace-migration-enum.service.ts to handle enum type name retrieval before column rename operations
- Removed automatic name computation from label in
formatFieldMetadataItemInput.tsto support independent API naming - Updated GraphQL schema, queries, and types across multiple files to support the new field synchronization functionality
15 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -187,6 +187,7 @@ export type CreateFieldInput = { | |||
| icon?: InputMaybe<Scalars['String']['input']>; | |||
| isActive?: InputMaybe<Scalars['Boolean']['input']>; | |||
| isCustom?: InputMaybe<Scalars['Boolean']['input']>; | |||
| isLabelSyncedWithName: Scalars['Boolean']['input']; | |||
There was a problem hiding this comment.
logic: isLabelSyncedWithName is required in CreateFieldInput but optional in UpdateFieldInput - this inconsistency could cause issues
packages/twenty-front/src/modules/object-metadata/hooks/useFieldMetadataItem.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-metadata/utils/formatFieldMetadataItemInput.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-metadata/validation-schemas/fieldMetadataItemSchema.ts
Show resolved
Hide resolved
.../modules/settings/data-model/fields/forms/components/SettingsDataModelFieldIconLabelForm.tsx
Show resolved
Hide resolved
| type SettingsDataModelFieldIconLabelFormProps = { | ||
| disabled?: boolean; | ||
| fieldMetadataItem?: FieldMetadataItem; | ||
| maxLength?: number; | ||
| }; | ||
|
|
||
| const infoCircleElementId = 'info-circle-id'; |
There was a problem hiding this comment.
style: infoCircleElementId should include a more unique prefix to avoid potential ID conflicts
packages/twenty-server/src/engine/metadata-modules/field-metadata/dtos/field-metadata.dto.ts
Show resolved
Hide resolved
Comment on lines
+150
to
+151
| @Field() | ||
| isLabelSyncedWithName?: boolean; |
There was a problem hiding this comment.
logic: Field should be marked as nullable since it's optional
packages/twenty-front/src/modules/object-metadata/hooks/useUpdateOneFieldMetadataItem.ts
Show resolved
Hide resolved
ijreilly
reviewed
Dec 2, 2024
|
|
||
| public async up(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query( | ||
| `ALTER TABLE "metadata"."fieldMetadata" ADD "isLabelSyncedWithName" boolean NOT NULL DEFAULT true`, |
There was a problem hiding this comment.
this defaults to false for objects, let's do the same?
ijreilly
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The recent addition of object renaming introduced issues with enum names. Enum names should follow the pattern
${schemaName}.${tableName}_${columnName}_enum. To address this, and to allow users to customize the API name (which is included in the enum name, columnName), this PR implements behavior similar to object renaming by introducing aisLabelSyncedWithNameboolean.