Refactor and fixes dropdown bugs #8807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements a comprehensive fix for nested dropdown menu issues by adding proper click-outside event handling and dropdown positioning.
- Added unique
listenerIdparameters to alluseListenClickOutsidehooks across components to properly scope click-outside events - Set
dropdownStrategy="absolute"andusePortalinMenuItemWithOptionDropdownto fix positioning and z-index issues - Added debug logging to track click event propagation and dropdown behavior
- Fixed potential event conflicts in nested dropdown scenarios by properly managing event listeners
- Improved click-outside handling in
RightDrawerby using dynamiclistenerIdbased on drawer page
💡 (4/5) You can add custom instructions or style guidelines for the bot here!
28 file(s) reviewed, 19 comment(s)
Edit PR Review Bot Settings | Greptile
...ges/twenty-front/src/modules/object-record/record-table/hooks/internal/useLeaveTableFocus.ts
Show resolved
Hide resolved
...ges/twenty-front/src/modules/object-record/record-table/hooks/internal/useLeaveTableFocus.ts
Show resolved
Hide resolved
...es/object-record/record-table/record-table-body/components/RecordTableBodyUnselectEffect.tsx
Show resolved
Hide resolved
...es/object-record/record-table/record-table-body/components/RecordTableBodyUnselectEffect.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/dropdown/components/Dropdown.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/utilities/pointer-event/hooks/useListenClickOutside.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/utilities/pointer-event/hooks/useListenClickOutsideV2.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/ViewFieldsVisibilityDropdownSection.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/ViewFieldsVisibilityDropdownSection.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MenuItemWithOptionDropdowns are bugged #8788
Fixes Unify dropdown behavior with floating-ui #8544
Fixes Regression - Margin top 2px #8793
Fixes Sort Order Dropdown #8791
Fixes Small fixes for the options menu #8789
Fixes Vertical Scroll Missing in "Company" Filter Dropdown #8827
Also :
No scroll and search container is shrinking
Icon buttons under dropdown are visible without blur :
(Not dropdown but let's fix it also)
Button create new without padding
Container is expanding
Also :
Font is cut at bottom ?
The component should flip and not resize in this situation
Also :
Bug with Phones input, the input stays open after value has been persisted, it should close, also bugs when editing, deleting, the value is persisted but in the dropdown the value stays the same.
Also :