Added containers for testing #8707
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added Docker container configurations for testing authentication and webhook functionality in the e2e testing environment.
- Added
mock-samlcontainer setup inpackages/twenty-e2e-testing/Makefilefor SAML authentication testing - Added
smtp4devcontainer in Makefile for email testing on ports 8090, 2525, and 143 - Created isolated webhook testing environment in
containers/webhook.ymlwith separate Redis instance to avoid conflicts - Configured webhook.site container with Laravel Echo server for real-time event handling
- Requires configuration of public/private key pair for mock-saml container before use
2 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+4
to
+11
| docker run \ | ||
| --name mock_saml \ | ||
| -p 4000:4000 \ | ||
| -e APP_URL="http://localhost:4000" \ | ||
| -e ENTITY_ID="https://saml.example.com/entityid" \ | ||
| -e PUBLIC_KEY= \ | ||
| -e PRIVATE_KEY= \ | ||
| -d boxyhq/mock-saml |
There was a problem hiding this comment.
style: No restart policy specified - container will not automatically restart if it crashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8469 and #6641
Webhook.site container must be in compose file as it requires 3 containers, one of them being Redis which is already used by Twenty. To prevent any problems with running 2 Redis containers simultaneously, network was created to separate both containers.