fix: Missing ellipsis for long calendar event names #8528
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented text truncation with ellipsis for long calendar event names to prevent overflow issues in the calendar view.
- Added
overflow: hiddenand removedflex: 1 0 autoinStyledEventscomponent in/packages/twenty-front/src/modules/activities/calendar/components/CalendarDayCardContent.tsx - Added
text-overflow: ellipsisandoverflow: hiddentoStyledTitlein/packages/twenty-front/src/modules/activities/calendar/components/CalendarEventRow.tsx - Set
flex-shrink: 0on fixed-width elements to prevent unwanted shrinking inCalendarEventRow - Added proper overflow handling in
StyledLabelscomponent to maintain layout integrity
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
39
to
46
| const StyledEvents = styled.div` | ||
| align-items: stretch; | ||
| display: flex; | ||
| flex: 1 0 auto; | ||
| flex-direction: column; | ||
| gap: ${({ theme }) => theme.spacing(3)}; | ||
| overflow: hidden; | ||
| `; |
There was a problem hiding this comment.
logic: Adding overflow:hidden alone won't create text ellipsis. The child components need width constraints and text-overflow properties.
asadath1395
force-pushed
the
fix-ellipsis-calendar
branch
from
b11dd51
to
0d28233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5267