fix - add new button on opportunity board company picker doesnt work #8488
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes the "New" button functionality in the opportunity board's company picker by implementing company creation and improving data fetching.
- Added company creation flow in
RecordBoardColumnNewOpportunity.tsxusingcreateCompanyOpportunityAndOpenRightDrawerfunction - Implemented right drawer opening after company creation with proper state management via
viewableRecordIdState - Added
cache-and-networkfetch policy inuseFilteredSearchEntityQuery.tsto ensure immediate visibility of newly created companies - Added error handling with
isDefinedchecks for company creation responses
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
...bject-record/record-board/record-board-column/components/RecordBoardColumnNewOpportunity.tsx
Show resolved
Hide resolved
...bject-record/record-board/record-board-column/components/RecordBoardColumnNewOpportunity.tsx
Show resolved
Hide resolved
| @@ -60,6 +60,7 @@ export const useFilteredSearchEntityQuery = ({ | |||
| filter: notFilter, | |||
| limit: limit ?? DEFAULT_SEARCH_REQUEST_LIMIT, | |||
| searchInput: searchFilter, | |||
| fetchPolicy: 'cache-and-network', | |||
There was a problem hiding this comment.
I am not sure about this one!
But the newly created entities won't get fetched without this.
There was a problem hiding this comment.
This should work out of the box, we shouldn't need to add this but maybe the optimistic effect isn't working properly for this request. It it's too time consuming, let's create an issue to solve that.
|
Is there an issue linked to this? Thanks! |
|
It seems like the add new button is itself removed! |
|
@ehconitin what do you mean? Do you have the issue link so I can remember? Thanks! |
|
Ohh I see you're right - Here a a few other issues:
|
|
LGTM for the code part, please create an issue for the optimistic rendering if you can't solve it easily in this PR. |
Closes #8455
opportunitybutton.mp4