Added TODO items #8458
Draft
Added TODO items #8458
+7
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs/FIXMEs:
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements Sentry error tracking in the PromiseRejectionEffect component and simplifies the Avatar component by removing Recoil state management.
- Added Sentry.captureException in
/packages/twenty-front/src/modules/error-handler/components/PromiseRejectionEffect.tsxfor error tracking - Replaced Recoil's invalidAvatarUrlsState with local useState in
/packages/twenty-ui/src/display/avatar/components/Avatar.tsx - Improved error message handling for ObjectMetadataItemNotFoundError with specific snackbar notifications
- Simplified Avatar component by making it more self-contained without external state dependencies
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -11,7 +11,8 @@ export const PromiseRejectionEffect = () => { | |||
| (event: PromiseRejectionEvent) => { | |||
| const error = event.reason; | |||
|
|
|||
| // TODO: connect Sentry here | |||
| Sentry.captureException(error); | |||
|
|
|||
| if (error instanceof ObjectMetadataItemNotFoundError) { | |||
| enqueueSnackBar( | |||
| `Error with custom object that cannot be found : ${event.reason}`, | |||
There was a problem hiding this comment.
style: Using event.reason here is redundant since we already have the error object. Consider using error.message for consistency with the else branch.
Comment on lines
12
to
+14
| const error = event.reason; | ||
|
|
||
| // TODO: connect Sentry here | ||
| Sentry.captureException(error); |
There was a problem hiding this comment.
style: Consider wrapping Sentry.captureException in try/catch to prevent potential errors in error handling itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Sentry and Removed Recoil
WIP