Remove `sync-metadata` and `IS_WORKSPACE_CREATION_V2_ENABLED` feature flag #16997

prastoin · 2026-01-07T17:18:22Z

Introduction

Followup of #17001 (review)
close twentyhq/core-team-issues#1910

We've completely decom the sync-metadata in production. We're now then removing its implementation in favor of the v2.

TODO:

Remove sync-metadata implem and commands
Remove workspace decorators
Type each deprecated field to deprecated on their workspaceEntity
Remove the workspace-sync-metadata folder entirely
remove workspace migration
workspace migration removal migration
remove the v2 references from workspace manager file names
remove the v2 references from workspace manager modules
Double check impact on translation file path updates

Note

Removed the gate logic
Remains some service v2 naming, serverless needs to be migrated on v2 fully
Removed workspaceMigration service app health consumption, making it always returning up ( no more down ) cc @FelixMalfait ( quite obsolete health check now, will require complete refactor once we introduce inter app dependency etc )

github-actions · 2026-01-07T17:29:41Z

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:45887

This environment will automatically shut down when the PR is closed or after 5 hours.

greptile-apps · 2026-01-07T17:45:16Z

Too many files changed for review.

greptile-apps · 2026-01-08T09:29:04Z

Too many files changed for review.

greptile-apps · 2026-01-08T09:34:47Z

Too many files changed for review.

greptile-apps · 2026-01-08T09:38:03Z

Too many files changed for review.

greptile-apps · 2026-01-08T09:44:47Z

Too many files changed for review.

greptile-apps · 2026-01-08T14:23:42Z

Too many files changed for review.

greptile-apps · 2026-01-08T14:27:10Z

Too many files changed for review.

greptile-apps · 2026-01-08T14:28:49Z

Too many files changed for review.

github-actions · 2026-01-08T14:33:39Z

📊 API Changes Report

GraphQL Schema Changes

[log]
Detected the following changes (1) between schemas:

[log] ✖ Enum value IS_WORKSPACE_CREATION_V2_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
⚠️ Breaking changes or errors detected in GraphQL schema

[log] 
Detected the following changes (1) between schemas:

[log] ✖  Enum value IS_WORKSPACE_CREATION_V2_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
Error generating diff

GraphQL Metadata Schema Changes

[log]
Detected the following changes (1) between schemas:

[log] ✖ Enum value IS_WORKSPACE_CREATION_V2_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
⚠️ Breaking changes or errors detected in GraphQL metadata schema

[log] 
Detected the following changes (1) between schemas:

[log] ✖  Enum value IS_WORKSPACE_CREATION_V2_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
Error generating diff

⚠️ Please review these API changes carefully before merging.

⚠️ Breaking Change Protocol

Breaking changes detected but PR title does not contain "breaking" - CI will pass but action needed.

🔄 Options:

If this IS a breaking change: Add "breaking" to your PR title and add BREAKING CHANGE: to your commit message
If this is NOT a breaking change: The API diff tool may have false positives - please review carefully

For breaking changes, add to commit message:

feat: add new API endpoint

BREAKING CHANGE: removed deprecated field from User schema

greptile-apps · 2026-01-08T14:33:56Z

Too many files changed for review.

greptile-apps · 2026-01-08T14:36:36Z

Too many files changed for review.

greptile-apps · 2026-01-08T14:37:42Z

Too many files changed for review.

greptile-apps · 2026-01-08T14:48:48Z

Too many files changed for review.

greptile-apps · 2026-01-08T14:49:57Z

Too many files changed for review.

greptile-apps · 2026-01-08T14:59:06Z

Too many files changed for review.

greptile-apps · 2026-01-08T15:00:17Z

Too many files changed for review.

greptile-apps · 2026-01-08T15:00:31Z

Too many files changed for review.

github-actions · 2026-01-08T15:07:07Z

📊 API Changes Report

GraphQL Schema Changes

[log]
Detected the following changes (1) between schemas:

[log] ✖ Enum value IS_WORKSPACE_CREATION_V2_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
⚠️ Breaking changes or errors detected in GraphQL schema

[log] 
Detected the following changes (1) between schemas:

[log] ✖  Enum value IS_WORKSPACE_CREATION_V2_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
Error generating diff

GraphQL Metadata Schema Changes

[log]
Detected the following changes (1) between schemas:

[log] ✖ Enum value IS_WORKSPACE_CREATION_V2_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
⚠️ Breaking changes or errors detected in GraphQL metadata schema

[log] 
Detected the following changes (1) between schemas:

[log] ✖  Enum value IS_WORKSPACE_CREATION_V2_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
Error generating diff

⚠️ Please review these API changes carefully before merging.

⚠️ Breaking Change Protocol

Breaking changes detected but PR title does not contain "breaking" - CI will pass but action needed.

🔄 Options:

If this IS a breaking change: Add "breaking" to your PR title and add BREAKING CHANGE: to your commit message
If this is NOT a breaking change: The API diff tool may have false positives - please review carefully

For breaking changes, add to commit message:

feat: add new API endpoint

BREAKING CHANGE: removed deprecated field from User schema

greptile-apps · 2026-01-08T15:07:25Z

Too many files changed for review.

greptile-apps · 2026-01-08T15:11:19Z

Too many files changed for review.

Weiko

LGTM! Finally saying goodbye to the sync-metadata! 🤧
Well done @prastoin ! 👏

Weiko · 2026-01-08T15:27:19Z

packages/twenty-server/src/engine/metadata-modules/role/constants/admin-role.ts

+  canBeAssignedToUsers: true,
+  canBeAssignedToAgents: false,
+  canBeAssignedToApiKeys: true,
+  applicationId: null, // TODO: Replace with Twenty application ID


What do you plan to do for that? Since this will be a dynamic value in a constant (should Pick pick applicationId in the first place?)

greptile-apps · 2026-01-08T15:44:21Z

Too many files changed for review.

twenty-eng-sync · 2026-01-08T15:56:21Z

Hey @prastoin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

twenty-eng-sync · 2026-01-08T15:56:22Z

Hey @prastoin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

greptile-apps · 2026-01-08T15:56:25Z

Too many files changed for review.

greptile-apps · 2026-01-08T15:56:39Z

Too many files changed for review.

greptile-apps · 2026-01-08T15:56:40Z

Too many files changed for review.

prastoin changed the title ~~Remove sync metadata~~ Remove sync-metadata and IS_WORKSPACE_CREATION_V2_ENABLED feature flag Jan 7, 2026

prastoin self-assigned this Jan 7, 2026

prastoin added -PR: wip -PR: awaiting author labels Jan 7, 2026

prastoin force-pushed the remove-sync-metadata branch from 5b76986 to 3e797b4 Compare January 8, 2026 09:27

prastoin added 17 commits January 8, 2026 10:32

chore(server): remove sync metadata command

96c94fb

chore(server): remove feature flag

9d7e7d2

chore(server): removing unused

51fc917

refactor(server): light weight workspace entity

01abd1f

chore(server): remove unused file

bb027b4

lint

fc5ed76

chore(server): remove all decorators

b18adaf

chore

03e186e

chore(server): remove gate

ff74d57

chore(server): remove pending migration command

148b739

chore(server): workspace-migration-runner

bfe0476

workspace manager workspace migration builder

6ed7fd3

chore

6e82331

chore: remove workspace migration runner folder

a4a51ec

lint

11f1e14

chore(server): remove prefill core view

1ff1ec3

chore

67b6b0a

prastoin force-pushed the remove-sync-metadata branch from 3e797b4 to 67b6b0a Compare January 8, 2026 09:33

lint

ab68c05

chore

17cda43

Weiko self-requested a review January 8, 2026 14:36

fix(server): restore data source creation on workspace creation

8c6f87b

fix(server): remove workspace migration from table scan post ws deletion

e812e6c

Weiko approved these changes Jan 8, 2026

View reviewed changes

prastoin added this pull request to the merge queue Jan 8, 2026

Merged via the queue into main with commit 942d2fe Jan 8, 2026
75 checks passed

prastoin deleted the remove-sync-metadata branch January 8, 2026 15:56

Remove sync-metadata and IS_WORKSPACE_CREATION_V2_ENABLED feature flag #16997

Remove sync-metadata and IS_WORKSPACE_CREATION_V2_ENABLED feature flag #16997

Uh oh!

Conversation

prastoin commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Introduction

TODO:

Note

Uh oh!

github-actions bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Jan 7, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

📊 API Changes Report

GraphQL Schema Changes

GraphQL Schema Changes

GraphQL Metadata Schema Changes

GraphQL Metadata Schema Changes

⚠️ Breaking Change Protocol

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

📊 API Changes Report

GraphQL Schema Changes

GraphQL Schema Changes

GraphQL Metadata Schema Changes

GraphQL Metadata Schema Changes

⚠️ Breaking Change Protocol

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

Weiko left a comment

Choose a reason for hiding this comment

Uh oh!

Weiko Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

Uh oh!

twenty-eng-sync bot commented Jan 8, 2026

Uh oh!

twenty-eng-sync bot commented Jan 8, 2026

Uh oh!

greptile-apps bot commented Jan 8, 2026

Uh oh!

Remove `sync-metadata` and `IS_WORKSPACE_CREATION_V2_ENABLED` feature flag #16997

Remove `sync-metadata` and `IS_WORKSPACE_CREATION_V2_ENABLED` feature flag #16997

prastoin commented Jan 7, 2026 •

edited

Loading

github-actions bot commented Jan 7, 2026 •

edited

Loading