[Dashboards] use select option colors when grouping by SELECT/MULTI_SELECT fields #16973
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
...es/page-layout/widgets/graph/graphWidgetPieChart/utils/transformGroupByDataToPieChartData.ts
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:56289 This environment will automatically shut down when the PR is closed or after 5 hours. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 9 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/twenty-front/src/modules/page-layout/widgets/graph/utils/__tests__/getSelectOptionColorForValue.test.ts">
<violation number="1" location="packages/twenty-front/src/modules/page-layout/widgets/graph/utils/__tests__/getSelectOptionColorForValue.test.ts:41">
P2: Test description claims to test for `undefined` selectOptions but the test case is missing. Add the missing test case for consistency with the description.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
...t/src/modules/page-layout/widgets/graph/utils/__tests__/getSelectOptionColorForValue.test.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/page-layout/widgets/graph/utils/createGraphColorRegistry.ts
Outdated
Show resolved
Hide resolved
...es/twenty-front/src/modules/page-layout/widgets/graph/utils/checkIsExplicitColorSelection.ts
Outdated
Show resolved
Hide resolved
|
@cubic-dev-ai review please |
@ehconitin I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 37 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/twenty-front/src/modules/page-layout/widgets/graph/utils/__tests__/determineChartItemColor.test.ts">
<violation number="1" location="packages/twenty-front/src/modules/page-layout/widgets/graph/utils/__tests__/determineChartItemColor.test.ts:39">
P2: Test description claims to test both `null` and `undefined` but only tests `null`. Consider either:
1. Adding a separate test case for `undefined`, or
2. Updating the description to say "null" only, or
3. Using `it.each` to test both values.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
...-front/src/modules/page-layout/widgets/graph/utils/__tests__/determineChartItemColor.test.ts
Outdated
Show resolved
Hide resolved
|
@ehconitin I believe you wanted to make a last change on this one |
|
Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
1 similar comment
|
Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
|
Thanks @ehconitin for your contribution! |
closes twentyhq/core-team-issues#2031
CleanShot.2026-01-07.at.00.31.33.mp4