fix onboarding for messaging #16729
fix onboarding for messaging #16729
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:40931 This environment will automatically shut down when the PR is closed or after 5 hours. |
Enhanced the WorkflowDiagramHandleSource component by adding a new hover effect. This includes a styled after pseudo-element that expands the clickable area, improving user interaction and accessibility.
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (currentUser?.onboardingStatus === OnboardingStatus.PROFILE_CREATION) { | ||
| return OnboardingStatus.SYNC_EMAIL; | ||
| if (currentWorkspace?.workspaceMembersCount === 1) { | ||
| return OnboardingStatus.SYNC_EMAIL; | ||
| } | ||
| return OnboardingStatus.INVITE_TEAM; | ||
| } | ||
| if ( | ||
| currentUser?.onboardingStatus === OnboardingStatus.SYNC_EMAIL && |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@neo773 I've tested this one and I have the following issues:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/twenty-front/src/pages/onboarding/InviteTeam.tsx">
<violation number="1">
P2: API call `sendInvitation` is now invoked even when `emails` is empty, causing an unnecessary GraphQL mutation. The conditional check should include the API call to avoid wasteful network requests when the user skips or provides no emails.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Co-authored-by: Charles Bochet <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
1 similar comment
|
Thanks @neo773 for your contribution! |
No description provided.