Only use CAPTCHA in logged out operations and pages #10607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR optimizes CAPTCHA loading by restricting it to specific authentication-related paths rather than loading it on every page, improving performance for logged-in users.
- Added
packages/twenty-front/src/modules/captcha/constants/CaptchaProtectedPaths.tsdefining specific routes (sign-in/up, verification, password reset, invite) where CAPTCHA is required - Added
packages/twenty-front/src/modules/captcha/utils/isCaptchaRequiredForPath.tsutility that checks if the current path needs CAPTCHA protection - Modified
CaptchaProvider.tsxto conditionally render CAPTCHA components only when required for the current path - Added
captcha-protected-fields.constants.tson the server side to limit CAPTCHA validation to specific GraphQL operations - Updated
captcha.guard.tsto skip CAPTCHA validation for operations not in the protected fields list
9 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| if (!CAPTCHA_PROTECTED_FIELDS.includes(operationName)) { | ||
| return true; | ||
| } | ||
|
|
||
| const { captchaToken: token } = ctx.getArgs(); |
There was a problem hiding this comment.
style: Consider handling the case where token is undefined more explicitly rather than defaulting to an empty string.
lucasbordeau
requested review from
martmull and
Weiko
and removed request for
lucasbordeau and
martmull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10235